2012-08-20 00:02:42 +00:00
|
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
|
|
|
|
#include "PositionedEventTargeting.h"
|
|
|
|
|
2014-03-17 06:56:53 +00:00
|
|
|
#include "mozilla/EventListenerManager.h"
|
2014-04-03 04:18:36 +00:00
|
|
|
#include "mozilla/EventStates.h"
|
2013-09-25 11:21:18 +00:00
|
|
|
#include "mozilla/MouseEvents.h"
|
2012-08-20 00:02:42 +00:00
|
|
|
#include "mozilla/Preferences.h"
|
|
|
|
#include "nsLayoutUtils.h"
|
|
|
|
#include "nsGkAtoms.h"
|
2015-02-07 11:17:12 +00:00
|
|
|
#include "nsFontMetrics.h"
|
2012-08-20 00:02:42 +00:00
|
|
|
#include "nsPrintfCString.h"
|
|
|
|
#include "mozilla/dom/Element.h"
|
2013-08-23 22:16:38 +00:00
|
|
|
#include "nsRegion.h"
|
2013-09-23 11:55:35 +00:00
|
|
|
#include "nsDeviceContext.h"
|
2013-09-30 21:26:04 +00:00
|
|
|
#include "nsIFrame.h"
|
2013-01-15 12:22:03 +00:00
|
|
|
#include <algorithm>
|
2014-11-06 13:05:51 +00:00
|
|
|
#include "LayersLogging.h"
|
|
|
|
|
|
|
|
// If debugging this code you may wish to enable this logging, and also
|
|
|
|
// uncomment the DumpFrameTree call near the bottom of the file.
|
|
|
|
#define PET_LOG(...)
|
|
|
|
// #define PET_LOG(...) printf_stderr("PET: " __VA_ARGS__);
|
2012-08-20 00:02:42 +00:00
|
|
|
|
|
|
|
namespace mozilla {
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The basic goal of FindFrameTargetedByInputEvent() is to find a good
|
|
|
|
* target element that can respond to mouse events. Both mouse events and touch
|
|
|
|
* events are targeted at this element. Note that even for touch events, we
|
|
|
|
* check responsiveness to mouse events. We assume Web authors
|
|
|
|
* designing for touch events will take their own steps to account for
|
|
|
|
* inaccurate touch events.
|
|
|
|
*
|
2015-07-31 13:22:46 +00:00
|
|
|
* GetClickableAncestor() encapsulates the heuristic that determines whether an
|
2012-08-20 00:02:42 +00:00
|
|
|
* element is expected to respond to mouse events. An element is deemed
|
|
|
|
* "clickable" if it has registered listeners for "click", "mousedown" or
|
|
|
|
* "mouseup", or is on a whitelist of element tags (<a>, <button>, <input>,
|
|
|
|
* <select>, <textarea>, <label>), or has role="button", or is a link, or
|
|
|
|
* is a suitable XUL element.
|
|
|
|
* Any descendant (in the same document) of a clickable element is also
|
|
|
|
* deemed clickable since events will propagate to the clickable element from its
|
|
|
|
* descendant.
|
|
|
|
*
|
|
|
|
* If the element directly under the event position is clickable (or
|
|
|
|
* event radii are disabled), we always use that element. Otherwise we collect
|
|
|
|
* all frames intersecting a rectangle around the event position (taking CSS
|
|
|
|
* transforms into account) and choose the best candidate in GetClosest().
|
2015-07-31 13:22:46 +00:00
|
|
|
* Only GetClickableAncestor() candidates are considered; if none are found,
|
2012-08-20 00:02:42 +00:00
|
|
|
* then we revert to targeting the element under the event position.
|
|
|
|
* We ignore candidates outside the document subtree rooted by the
|
|
|
|
* document of the element directly under the event position. This ensures that
|
|
|
|
* event listeners in ancestor documents don't make it completely impossible
|
|
|
|
* to target a non-clickable element in a child document.
|
|
|
|
*
|
|
|
|
* When both a frame and its ancestor are in the candidate list, we ignore
|
|
|
|
* the ancestor. Otherwise a large ancestor element with a mouse event listener
|
|
|
|
* and some descendant elements that need to be individually targetable would
|
|
|
|
* disable intelligent targeting of those descendants within its bounds.
|
|
|
|
*
|
|
|
|
* GetClosest() computes the transformed axis-aligned bounds of each
|
|
|
|
* candidate frame, then computes the Manhattan distance from the event point
|
|
|
|
* to the bounds rect (which can be zero). The frame with the
|
|
|
|
* shortest distance is chosen. For visited links we multiply the distance
|
|
|
|
* by a specified constant weight; this can be used to make visited links
|
|
|
|
* more or less likely to be targeted than non-visited links.
|
|
|
|
*/
|
|
|
|
|
|
|
|
struct EventRadiusPrefs
|
|
|
|
{
|
|
|
|
uint32_t mVisitedWeight; // in percent, i.e. default is 100
|
|
|
|
uint32_t mSideRadii[4]; // TRBL order, in millimetres
|
|
|
|
bool mEnabled;
|
|
|
|
bool mRegistered;
|
2013-01-24 14:53:18 +00:00
|
|
|
bool mTouchOnly;
|
2014-11-04 14:52:16 +00:00
|
|
|
bool mRepositionEventCoords;
|
2015-05-15 20:20:12 +00:00
|
|
|
bool mTouchClusterDetectionDisabled;
|
2015-02-07 11:17:12 +00:00
|
|
|
uint32_t mLimitReadableSize;
|
2012-08-20 00:02:42 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static EventRadiusPrefs sMouseEventRadiusPrefs;
|
|
|
|
static EventRadiusPrefs sTouchEventRadiusPrefs;
|
|
|
|
|
|
|
|
static const EventRadiusPrefs*
|
2014-08-04 05:28:46 +00:00
|
|
|
GetPrefsFor(EventClassID aEventClassID)
|
2012-08-20 00:02:42 +00:00
|
|
|
{
|
|
|
|
EventRadiusPrefs* prefs = nullptr;
|
|
|
|
const char* prefBranch = nullptr;
|
2014-08-04 05:28:53 +00:00
|
|
|
if (aEventClassID == eTouchEventClass) {
|
2012-08-20 00:02:42 +00:00
|
|
|
prefBranch = "touch";
|
|
|
|
prefs = &sTouchEventRadiusPrefs;
|
2014-08-04 05:28:50 +00:00
|
|
|
} else if (aEventClassID == eMouseEventClass) {
|
2012-08-20 00:02:42 +00:00
|
|
|
// Mostly for testing purposes
|
|
|
|
prefBranch = "mouse";
|
|
|
|
prefs = &sMouseEventRadiusPrefs;
|
|
|
|
} else {
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!prefs->mRegistered) {
|
|
|
|
prefs->mRegistered = true;
|
|
|
|
|
|
|
|
nsPrintfCString enabledPref("ui.%s.radius.enabled", prefBranch);
|
|
|
|
Preferences::AddBoolVarCache(&prefs->mEnabled, enabledPref.get(), false);
|
|
|
|
|
|
|
|
nsPrintfCString visitedWeightPref("ui.%s.radius.visitedWeight", prefBranch);
|
|
|
|
Preferences::AddUintVarCache(&prefs->mVisitedWeight, visitedWeightPref.get(), 100);
|
|
|
|
|
|
|
|
static const char prefNames[4][9] =
|
|
|
|
{ "topmm", "rightmm", "bottommm", "leftmm" };
|
|
|
|
for (int32_t i = 0; i < 4; ++i) {
|
|
|
|
nsPrintfCString radiusPref("ui.%s.radius.%s", prefBranch, prefNames[i]);
|
|
|
|
Preferences::AddUintVarCache(&prefs->mSideRadii[i], radiusPref.get(), 0);
|
|
|
|
}
|
2013-01-24 14:53:18 +00:00
|
|
|
|
2014-08-04 05:28:50 +00:00
|
|
|
if (aEventClassID == eMouseEventClass) {
|
2013-01-24 14:53:18 +00:00
|
|
|
Preferences::AddBoolVarCache(&prefs->mTouchOnly,
|
|
|
|
"ui.mouse.radius.inputSource.touchOnly", true);
|
|
|
|
} else {
|
|
|
|
prefs->mTouchOnly = false;
|
|
|
|
}
|
2014-11-04 14:52:16 +00:00
|
|
|
|
|
|
|
nsPrintfCString repositionPref("ui.%s.radius.reposition", prefBranch);
|
|
|
|
Preferences::AddBoolVarCache(&prefs->mRepositionEventCoords, repositionPref.get(), false);
|
2014-11-24 14:33:06 +00:00
|
|
|
|
2015-05-15 20:20:12 +00:00
|
|
|
nsPrintfCString touchClusterPref("ui.zoomedview.disabled", prefBranch);
|
|
|
|
Preferences::AddBoolVarCache(&prefs->mTouchClusterDetectionDisabled, touchClusterPref.get(), true);
|
2015-02-07 11:17:12 +00:00
|
|
|
|
|
|
|
nsPrintfCString limitReadableSizePref("ui.zoomedview.limitReadableSize", prefBranch);
|
|
|
|
Preferences::AddUintVarCache(&prefs->mLimitReadableSize, limitReadableSizePref.get(), 8);
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return prefs;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
HasMouseListener(nsIContent* aContent)
|
|
|
|
{
|
2014-03-17 06:56:53 +00:00
|
|
|
if (EventListenerManager* elm = aContent->GetExistingListenerManager()) {
|
2013-10-22 23:32:04 +00:00
|
|
|
return elm->HasListenersFor(nsGkAtoms::onclick) ||
|
|
|
|
elm->HasListenersFor(nsGkAtoms::onmousedown) ||
|
|
|
|
elm->HasListenersFor(nsGkAtoms::onmouseup);
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
2013-10-22 23:32:04 +00:00
|
|
|
|
|
|
|
return false;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
2013-10-17 18:42:48 +00:00
|
|
|
static bool gTouchEventsRegistered = false;
|
|
|
|
static int32_t gTouchEventsEnabled = 0;
|
|
|
|
|
|
|
|
static bool
|
|
|
|
HasTouchListener(nsIContent* aContent)
|
|
|
|
{
|
2014-03-17 06:56:53 +00:00
|
|
|
EventListenerManager* elm = aContent->GetExistingListenerManager();
|
2013-10-17 18:42:48 +00:00
|
|
|
if (!elm) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!gTouchEventsRegistered) {
|
|
|
|
Preferences::AddIntVarCache(&gTouchEventsEnabled,
|
|
|
|
"dom.w3c_touch_events.enabled", gTouchEventsEnabled);
|
|
|
|
gTouchEventsRegistered = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!gTouchEventsEnabled) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return elm->HasListenersFor(nsGkAtoms::ontouchstart) ||
|
|
|
|
elm->HasListenersFor(nsGkAtoms::ontouchend);
|
|
|
|
}
|
|
|
|
|
Bug 1181763 - Allow the target fluffing code to fluff even when directly hitting something clickable. r=roc
There is a common pattern on the web where a click listener is registered on a
container element high up in the DOM tree, and based on the target of the click
events, it performs the appropriate action. In such cases, our existing fluffing
code was not getting activated anywhere inside the container, because the entire
container was considered clickable. However, this is not user-friendly because
often the actual targets inside the container are small and hard to hit. Also,
the fluffing code will often take the container element itself as the target,
even if the user actually hit something inside the container.
This patch changes this behaviour so when an event hits inside a clickable
container, fluffing still occurs, but is restricted to DOM descendants of the
container. This allows fluffing to work in the above scenarios, and since the
events will bubble up to the container, the listeners on the container are
guaranteed to still trigger.
2015-07-17 12:36:00 +00:00
|
|
|
static bool
|
|
|
|
IsDescendant(nsIFrame* aFrame, nsIContent* aAncestor, nsAutoString* aLabelTargetId)
|
|
|
|
{
|
|
|
|
for (nsIContent* content = aFrame->GetContent(); content;
|
|
|
|
content = content->GetFlattenedTreeParent()) {
|
|
|
|
if (aLabelTargetId && content->IsHTMLElement(nsGkAtoms::label)) {
|
|
|
|
content->GetAttr(kNameSpaceID_None, nsGkAtoms::_for, *aLabelTargetId);
|
|
|
|
}
|
|
|
|
if (content == aAncestor) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-07-31 13:22:46 +00:00
|
|
|
static nsIContent*
|
|
|
|
GetClickableAncestor(nsIFrame* aFrame, nsIAtom* stopAt = nullptr, nsAutoString* aLabelTargetId = nullptr)
|
2012-08-20 00:02:42 +00:00
|
|
|
{
|
|
|
|
// Input events propagate up the content tree so we'll follow the content
|
|
|
|
// ancestors to look for elements accepting the click.
|
|
|
|
for (nsIContent* content = aFrame->GetContent(); content;
|
|
|
|
content = content->GetFlattenedTreeParent()) {
|
2015-03-03 11:09:00 +00:00
|
|
|
if (stopAt && content->IsHTMLElement(stopAt)) {
|
2013-08-05 18:25:27 +00:00
|
|
|
break;
|
|
|
|
}
|
2013-10-17 18:42:48 +00:00
|
|
|
if (HasTouchListener(content) || HasMouseListener(content)) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
2015-03-03 11:09:00 +00:00
|
|
|
if (content->IsAnyOfHTMLElements(nsGkAtoms::button,
|
|
|
|
nsGkAtoms::input,
|
|
|
|
nsGkAtoms::select,
|
2015-07-02 19:16:25 +00:00
|
|
|
nsGkAtoms::textarea)) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2015-07-02 19:16:25 +00:00
|
|
|
}
|
|
|
|
if (content->IsHTMLElement(nsGkAtoms::label)) {
|
|
|
|
if (aLabelTargetId) {
|
|
|
|
content->GetAttr(kNameSpaceID_None, nsGkAtoms::_for, *aLabelTargetId);
|
|
|
|
}
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2015-03-03 11:09:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Bug 921928: we don't have access to the content of remote iframe.
|
|
|
|
// So fluffing won't go there. We do an optimistic assumption here:
|
|
|
|
// that the content of the remote iframe needs to be a target.
|
|
|
|
if (content->IsHTMLElement(nsGkAtoms::iframe) &&
|
|
|
|
content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::mozbrowser,
|
|
|
|
nsGkAtoms::_true, eIgnoreCase) &&
|
|
|
|
content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::Remote,
|
|
|
|
nsGkAtoms::_true, eIgnoreCase)) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
2015-03-03 11:09:00 +00:00
|
|
|
|
|
|
|
// See nsCSSFrameConstructor::FindXULTagData. This code is not
|
|
|
|
// really intended to be used with XUL, though.
|
|
|
|
if (content->IsAnyOfXULElements(nsGkAtoms::button,
|
|
|
|
nsGkAtoms::checkbox,
|
|
|
|
nsGkAtoms::radio,
|
|
|
|
nsGkAtoms::autorepeatbutton,
|
|
|
|
nsGkAtoms::menu,
|
|
|
|
nsGkAtoms::menubutton,
|
|
|
|
nsGkAtoms::menuitem,
|
|
|
|
nsGkAtoms::menulist,
|
|
|
|
nsGkAtoms::scrollbarbutton,
|
|
|
|
nsGkAtoms::resizer)) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2015-03-03 11:09:00 +00:00
|
|
|
}
|
|
|
|
|
2014-02-26 14:03:32 +00:00
|
|
|
static nsIContent::AttrValuesArray clickableRoles[] =
|
|
|
|
{ &nsGkAtoms::button, &nsGkAtoms::key, nullptr };
|
|
|
|
if (content->FindAttrValueIn(kNameSpaceID_None, nsGkAtoms::role,
|
|
|
|
clickableRoles, eIgnoreCase) >= 0) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
2013-08-06 10:33:29 +00:00
|
|
|
if (content->IsEditable()) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2013-08-06 10:33:29 +00:00
|
|
|
}
|
2012-08-20 00:02:42 +00:00
|
|
|
nsCOMPtr<nsIURI> linkURI;
|
|
|
|
if (content->IsLink(getter_AddRefs(linkURI))) {
|
2015-07-31 13:22:46 +00:00
|
|
|
return content;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
}
|
2015-07-31 13:22:46 +00:00
|
|
|
return nullptr;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static nscoord
|
|
|
|
AppUnitsFromMM(nsIFrame* aFrame, uint32_t aMM, bool aVertical)
|
|
|
|
{
|
|
|
|
nsPresContext* pc = aFrame->PresContext();
|
|
|
|
float result = float(aMM) *
|
2014-03-11 15:14:51 +00:00
|
|
|
(pc->DeviceContext()->AppUnitsPerPhysicalInch() / MM_PER_INCH_FLOAT);
|
2012-08-20 00:02:42 +00:00
|
|
|
return NSToCoordRound(result);
|
|
|
|
}
|
|
|
|
|
2014-01-29 13:54:25 +00:00
|
|
|
/**
|
|
|
|
* Clip aRect with the bounds of aFrame in the coordinate system of
|
|
|
|
* aRootFrame. aRootFrame is an ancestor of aFrame.
|
|
|
|
*/
|
|
|
|
static nsRect
|
|
|
|
ClipToFrame(nsIFrame* aRootFrame, nsIFrame* aFrame, nsRect& aRect)
|
|
|
|
{
|
|
|
|
nsRect bound = nsLayoutUtils::TransformFrameRectToAncestor(
|
|
|
|
aFrame, nsRect(nsPoint(0, 0), aFrame->GetSize()), aRootFrame);
|
|
|
|
nsRect result = bound.Intersect(aRect);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
static nsRect
|
|
|
|
GetTargetRect(nsIFrame* aRootFrame, const nsPoint& aPointRelativeToRootFrame,
|
2014-11-03 14:43:52 +00:00
|
|
|
nsIFrame* aRestrictToDescendants, const EventRadiusPrefs* aPrefs,
|
|
|
|
uint32_t aFlags)
|
2012-08-20 00:02:42 +00:00
|
|
|
{
|
2013-03-06 08:05:55 +00:00
|
|
|
nsMargin m(AppUnitsFromMM(aRootFrame, aPrefs->mSideRadii[0], true),
|
2012-08-20 00:02:42 +00:00
|
|
|
AppUnitsFromMM(aRootFrame, aPrefs->mSideRadii[1], false),
|
2013-03-06 08:05:55 +00:00
|
|
|
AppUnitsFromMM(aRootFrame, aPrefs->mSideRadii[2], true),
|
|
|
|
AppUnitsFromMM(aRootFrame, aPrefs->mSideRadii[3], false));
|
2012-08-20 00:02:42 +00:00
|
|
|
nsRect r(aPointRelativeToRootFrame, nsSize(0,0));
|
|
|
|
r.Inflate(m);
|
2014-11-03 14:43:52 +00:00
|
|
|
if (!(aFlags & INPUT_IGNORE_ROOT_SCROLL_FRAME)) {
|
|
|
|
// Don't clip this rect to the root scroll frame if the flag to ignore the
|
|
|
|
// root scroll frame is set. Note that the GetClosest code will still enforce
|
|
|
|
// that the target found is a descendant of aRestrictToDescendants.
|
|
|
|
r = ClipToFrame(aRootFrame, aRestrictToDescendants, r);
|
|
|
|
}
|
|
|
|
return r;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static float
|
|
|
|
ComputeDistanceFromRect(const nsPoint& aPoint, const nsRect& aRect)
|
|
|
|
{
|
2013-01-15 12:22:03 +00:00
|
|
|
nscoord dx = std::max(0, std::max(aRect.x - aPoint.x, aPoint.x - aRect.XMost()));
|
|
|
|
nscoord dy = std::max(0, std::max(aRect.y - aPoint.y, aPoint.y - aRect.YMost()));
|
2012-08-20 00:02:42 +00:00
|
|
|
return float(NS_hypot(dx, dy));
|
|
|
|
}
|
|
|
|
|
2013-07-30 16:22:46 +00:00
|
|
|
static float
|
|
|
|
ComputeDistanceFromRegion(const nsPoint& aPoint, const nsRegion& aRegion)
|
|
|
|
{
|
2013-08-03 05:46:19 +00:00
|
|
|
MOZ_ASSERT(!aRegion.IsEmpty(), "can't compute distance between point and empty region");
|
2013-07-30 16:22:46 +00:00
|
|
|
nsRegionRectIterator iter(aRegion);
|
|
|
|
const nsRect* r;
|
|
|
|
float minDist = -1;
|
|
|
|
while ((r = iter.Next()) != nullptr) {
|
|
|
|
float dist = ComputeDistanceFromRect(aPoint, *r);
|
|
|
|
if (dist < minDist || minDist < 0) {
|
|
|
|
minDist = dist;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return minDist;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Subtract aRegion from aExposedRegion as long as that doesn't make the
|
|
|
|
// exposed region get too complex or removes a big chunk of the exposed region.
|
|
|
|
static void
|
|
|
|
SubtractFromExposedRegion(nsRegion* aExposedRegion, const nsRegion& aRegion)
|
|
|
|
{
|
|
|
|
if (aRegion.IsEmpty())
|
|
|
|
return;
|
|
|
|
|
|
|
|
nsRegion tmp;
|
|
|
|
tmp.Sub(*aExposedRegion, aRegion);
|
|
|
|
// Don't let *aExposedRegion get too complex, but don't let it fluff out to
|
|
|
|
// its bounds either. Do let aExposedRegion get more complex if by doing so
|
|
|
|
// we reduce its area by at least half.
|
|
|
|
if (tmp.GetNumRects() <= 15 || tmp.Area() <= aExposedRegion->Area()/2) {
|
|
|
|
*aExposedRegion = tmp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-07-02 19:16:25 +00:00
|
|
|
// Search in the list of frames aCandidates if the element with the id "aLabelTargetId"
|
|
|
|
// is present.
|
|
|
|
static bool IsElementPresent(nsTArray<nsIFrame*>& aCandidates, const nsAutoString& aLabelTargetId)
|
|
|
|
{
|
|
|
|
for (uint32_t i = 0; i < aCandidates.Length(); ++i) {
|
|
|
|
nsIFrame* f = aCandidates[i];
|
|
|
|
nsIContent* aContent = f->GetContent();
|
|
|
|
if (aContent && aContent->IsElement()) {
|
|
|
|
if (aContent->GetID() && aLabelTargetId == nsAtomString(aContent->GetID())) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
static nsIFrame*
|
|
|
|
GetClosest(nsIFrame* aRoot, const nsPoint& aPointRelativeToRootFrame,
|
2013-07-30 16:22:46 +00:00
|
|
|
const nsRect& aTargetRect, const EventRadiusPrefs* aPrefs,
|
Bug 1181763 - Allow the target fluffing code to fluff even when directly hitting something clickable. r=roc
There is a common pattern on the web where a click listener is registered on a
container element high up in the DOM tree, and based on the target of the click
events, it performs the appropriate action. In such cases, our existing fluffing
code was not getting activated anywhere inside the container, because the entire
container was considered clickable. However, this is not user-friendly because
often the actual targets inside the container are small and hard to hit. Also,
the fluffing code will often take the container element itself as the target,
even if the user actually hit something inside the container.
This patch changes this behaviour so when an event hits inside a clickable
container, fluffing still occurs, but is restricted to DOM descendants of the
container. This allows fluffing to work in the above scenarios, and since the
events will bubble up to the container, the listeners on the container are
guaranteed to still trigger.
2015-07-17 12:36:00 +00:00
|
|
|
nsIFrame* aRestrictToDescendants, nsIContent* aClickableAncestor,
|
|
|
|
nsTArray<nsIFrame*>& aCandidates, int32_t* aElementsInCluster)
|
2012-08-20 00:02:42 +00:00
|
|
|
{
|
2015-07-31 13:22:46 +00:00
|
|
|
std::vector<nsIContent*> mContentsInCluster; // List of content elements in the cluster without duplicate
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIFrame* bestTarget = nullptr;
|
|
|
|
// Lower is better; distance is in appunits
|
|
|
|
float bestDistance = 1e6f;
|
2013-07-30 16:22:46 +00:00
|
|
|
nsRegion exposedRegion(aTargetRect);
|
2012-08-20 00:02:42 +00:00
|
|
|
for (uint32_t i = 0; i < aCandidates.Length(); ++i) {
|
|
|
|
nsIFrame* f = aCandidates[i];
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG("Checking candidate %p\n", f);
|
2013-07-30 16:22:46 +00:00
|
|
|
|
|
|
|
bool preservesAxisAlignedRectangles = false;
|
|
|
|
nsRect borderBox = nsLayoutUtils::TransformFrameRectToAncestor(f,
|
|
|
|
nsRect(nsPoint(0, 0), f->GetSize()), aRoot, &preservesAxisAlignedRectangles);
|
|
|
|
nsRegion region;
|
|
|
|
region.And(exposedRegion, borderBox);
|
2013-08-03 05:46:19 +00:00
|
|
|
if (region.IsEmpty()) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG(" candidate %p had empty hit region\n", f);
|
2013-08-03 05:46:19 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2013-07-30 16:22:46 +00:00
|
|
|
if (preservesAxisAlignedRectangles) {
|
|
|
|
// Subtract from the exposed region if we have a transform that won't make
|
|
|
|
// the bounds include a bunch of area that we don't actually cover.
|
|
|
|
SubtractFromExposedRegion(&exposedRegion, region);
|
|
|
|
}
|
|
|
|
|
2015-07-02 19:16:25 +00:00
|
|
|
nsAutoString labelTargetId;
|
2015-07-31 13:22:46 +00:00
|
|
|
if (aClickableAncestor && !IsDescendant(f, aClickableAncestor, &labelTargetId)) {
|
|
|
|
PET_LOG(" candidate %p is not a descendant of required ancestor\n", f);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
nsIContent* clickableContent = GetClickableAncestor(f, nsGkAtoms::body, &labelTargetId);
|
|
|
|
if (!aClickableAncestor && !clickableContent) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG(" candidate %p was not clickable\n", f);
|
2012-08-20 00:02:42 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
// If our current closest frame is a descendant of 'f', skip 'f' (prefer
|
|
|
|
// the nested frame).
|
|
|
|
if (bestTarget && nsLayoutUtils::IsProperAncestorFrameCrossDoc(f, bestTarget, aRoot)) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG(" candidate %p was ancestor for bestTarget %p\n", f, bestTarget);
|
2012-08-20 00:02:42 +00:00
|
|
|
continue;
|
|
|
|
}
|
2015-07-31 13:22:46 +00:00
|
|
|
if (!aClickableAncestor && !nsLayoutUtils::IsAncestorFrameCrossDoc(aRestrictToDescendants, f, aRoot)) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG(" candidate %p was not descendant of restrictroot %p\n", f, aRestrictToDescendants);
|
2012-08-20 00:02:42 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-07-02 19:16:25 +00:00
|
|
|
// If the first clickable ancestor of f is a label element
|
|
|
|
// and "for" attribute is present in label element, search the frame list for the "for" element
|
|
|
|
// If this element is present in the current list, do not count the frame in
|
|
|
|
// the cluster elements counter
|
|
|
|
if (labelTargetId.IsEmpty() || !IsElementPresent(aCandidates, labelTargetId)) {
|
2015-07-31 13:22:46 +00:00
|
|
|
if (std::find(mContentsInCluster.begin(), mContentsInCluster.end(), clickableContent) == mContentsInCluster.end()) {
|
|
|
|
mContentsInCluster.push_back(clickableContent);
|
|
|
|
}
|
2015-07-02 19:16:25 +00:00
|
|
|
}
|
2014-11-24 14:33:06 +00:00
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
// distance is in appunits
|
2013-07-30 16:22:46 +00:00
|
|
|
float distance = ComputeDistanceFromRegion(aPointRelativeToRootFrame, region);
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIContent* content = f->GetContent();
|
|
|
|
if (content && content->IsElement() &&
|
2014-04-03 04:18:36 +00:00
|
|
|
content->AsElement()->State().HasState(
|
|
|
|
EventStates(NS_EVENT_STATE_VISITED))) {
|
2012-08-20 00:02:42 +00:00
|
|
|
distance *= aPrefs->mVisitedWeight / 100.0f;
|
|
|
|
}
|
|
|
|
if (distance < bestDistance) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG(" candidate %p is the new best\n", f);
|
2012-08-20 00:02:42 +00:00
|
|
|
bestDistance = distance;
|
|
|
|
bestTarget = f;
|
|
|
|
}
|
|
|
|
}
|
2015-07-31 13:22:46 +00:00
|
|
|
*aElementsInCluster = mContentsInCluster.size();
|
2012-08-20 00:02:42 +00:00
|
|
|
return bestTarget;
|
|
|
|
}
|
|
|
|
|
2015-02-07 11:17:12 +00:00
|
|
|
/*
|
|
|
|
* Return always true when touch cluster detection is OFF.
|
2015-06-12 20:05:21 +00:00
|
|
|
* When cluster detection is ON, return true:
|
|
|
|
* if the text inside the frame is readable (by human eyes)
|
|
|
|
* or
|
|
|
|
* if the structure is too complex to determine the size.
|
|
|
|
* In both cases, the frame is considered as clickable.
|
|
|
|
*
|
|
|
|
* Frames with a too small size will return false.
|
|
|
|
* In this case, the frame is considered not clickable.
|
2015-02-07 11:17:12 +00:00
|
|
|
*/
|
|
|
|
static bool
|
|
|
|
IsElementClickableAndReadable(nsIFrame* aFrame, WidgetGUIEvent* aEvent, const EventRadiusPrefs* aPrefs)
|
|
|
|
{
|
2015-05-15 20:20:12 +00:00
|
|
|
if (aPrefs->mTouchClusterDetectionDisabled) {
|
2015-02-07 11:17:12 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (aEvent->mClass != eMouseEventClass) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint32_t limitReadableSize = aPrefs->mLimitReadableSize;
|
|
|
|
nsSize frameSize = aFrame->GetSize();
|
|
|
|
nsPresContext* pc = aFrame->PresContext();
|
|
|
|
nsIPresShell* presShell = pc->PresShell();
|
2015-03-06 23:07:59 +00:00
|
|
|
float cumulativeResolution = presShell->GetCumulativeResolution();
|
|
|
|
if ((pc->AppUnitsToGfxUnits(frameSize.height) * cumulativeResolution) < limitReadableSize ||
|
|
|
|
(pc->AppUnitsToGfxUnits(frameSize.width) * cumulativeResolution) < limitReadableSize) {
|
2015-02-07 11:17:12 +00:00
|
|
|
return false;
|
|
|
|
}
|
2015-06-12 20:05:21 +00:00
|
|
|
// We want to detect small clickable text elements using the font size.
|
|
|
|
// Two common cases are supported for now:
|
|
|
|
// 1. text node
|
|
|
|
// 2. any element with only one child of type text node
|
|
|
|
// All the other cases are currently ignored.
|
|
|
|
nsIContent *content = aFrame->GetContent();
|
|
|
|
bool testFontSize = false;
|
|
|
|
if (content) {
|
|
|
|
nsINodeList* childNodes = content->ChildNodes();
|
|
|
|
uint32_t childNodeCount = childNodes->Length();
|
|
|
|
if ((content->IsNodeOfType(nsINode::eTEXT)) ||
|
|
|
|
// click occurs on the text inside <a></a> or other clickable tags with text inside
|
|
|
|
|
|
|
|
(childNodeCount == 1 && childNodes->Item(0) &&
|
|
|
|
childNodes->Item(0)->IsNodeOfType(nsINode::eTEXT))) {
|
|
|
|
// The click occurs on an element with only one text node child. In this case, the font size
|
|
|
|
// can be tested.
|
|
|
|
// The number of child nodes is tested to avoid the following cases (See bug 1172488):
|
|
|
|
// Some jscript libraries transform text elements into Canvas elements but keep the text nodes
|
|
|
|
// with a very small size (1px) to handle the selection of text.
|
|
|
|
// With such libraries, the font size of the text elements is not relevant to detect small elements.
|
|
|
|
|
|
|
|
testFontSize = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (testFontSize) {
|
|
|
|
nsRefPtr<nsFontMetrics> fm;
|
|
|
|
nsLayoutUtils::GetFontMetricsForFrame(aFrame, getter_AddRefs(fm),
|
|
|
|
nsLayoutUtils::FontSizeInflationFor(aFrame));
|
|
|
|
if (fm && fm->EmHeight() > 0 && // See bug 1171731
|
2015-06-05 14:25:16 +00:00
|
|
|
(pc->AppUnitsToGfxUnits(fm->EmHeight()) * cumulativeResolution) < limitReadableSize) {
|
2015-02-07 11:17:12 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIFrame*
|
2014-11-04 14:52:16 +00:00
|
|
|
FindFrameTargetedByInputEvent(WidgetGUIEvent* aEvent,
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIFrame* aRootFrame,
|
|
|
|
const nsPoint& aPointRelativeToRootFrame,
|
|
|
|
uint32_t aFlags)
|
|
|
|
{
|
2013-07-26 02:31:41 +00:00
|
|
|
uint32_t flags = (aFlags & INPUT_IGNORE_ROOT_SCROLL_FRAME) ?
|
|
|
|
nsLayoutUtils::IGNORE_ROOT_SCROLL_FRAME : 0;
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIFrame* target =
|
2013-07-26 02:31:41 +00:00
|
|
|
nsLayoutUtils::GetFrameForPoint(aRootFrame, aPointRelativeToRootFrame, flags);
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG("Found initial target %p for event class %s point %s relative to root frame %p\n",
|
|
|
|
target, (aEvent->mClass == eMouseEventClass ? "mouse" :
|
|
|
|
(aEvent->mClass == eTouchEventClass ? "touch" : "other")),
|
|
|
|
mozilla::layers::Stringify(aPointRelativeToRootFrame).c_str(), aRootFrame);
|
2013-01-24 14:53:18 +00:00
|
|
|
|
2014-08-04 05:28:46 +00:00
|
|
|
const EventRadiusPrefs* prefs = GetPrefsFor(aEvent->mClass);
|
2015-02-07 11:17:12 +00:00
|
|
|
if (!prefs || !prefs->mEnabled) {
|
|
|
|
PET_LOG("Retargeting disabled\n");
|
|
|
|
return target;
|
|
|
|
}
|
Bug 1181763 - Allow the target fluffing code to fluff even when directly hitting something clickable. r=roc
There is a common pattern on the web where a click listener is registered on a
container element high up in the DOM tree, and based on the target of the click
events, it performs the appropriate action. In such cases, our existing fluffing
code was not getting activated anywhere inside the container, because the entire
container was considered clickable. However, this is not user-friendly because
often the actual targets inside the container are small and hard to hit. Also,
the fluffing code will often take the container element itself as the target,
even if the user actually hit something inside the container.
This patch changes this behaviour so when an event hits inside a clickable
container, fluffing still occurs, but is restricted to DOM descendants of the
container. This allows fluffing to work in the above scenarios, and since the
events will bubble up to the container, the listeners on the container are
guaranteed to still trigger.
2015-07-17 12:36:00 +00:00
|
|
|
nsIContent* clickableAncestor = nullptr;
|
2015-07-31 13:22:46 +00:00
|
|
|
if (target) {
|
|
|
|
clickableAncestor = GetClickableAncestor(target, nsGkAtoms::body);
|
|
|
|
if (clickableAncestor) {
|
|
|
|
if (!IsElementClickableAndReadable(target, aEvent, prefs)) {
|
|
|
|
aEvent->AsMouseEventBase()->hitCluster = true;
|
|
|
|
}
|
|
|
|
PET_LOG("Target %p is clickable\n", target);
|
2015-02-07 11:17:12 +00:00
|
|
|
}
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
2013-01-24 14:53:18 +00:00
|
|
|
// Do not modify targeting for actual mouse hardware; only for mouse
|
|
|
|
// events generated by touch-screen hardware.
|
2014-08-04 05:28:50 +00:00
|
|
|
if (aEvent->mClass == eMouseEventClass &&
|
2013-01-24 14:53:18 +00:00
|
|
|
prefs->mTouchOnly &&
|
2013-10-22 08:55:20 +00:00
|
|
|
aEvent->AsMouseEvent()->inputSource !=
|
|
|
|
nsIDOMMouseEvent::MOZ_SOURCE_TOUCH) {
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG("Mouse input event is not from a touch source\n");
|
2013-10-22 08:55:20 +00:00
|
|
|
return target;
|
2013-01-24 14:53:18 +00:00
|
|
|
}
|
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
// If the exact target is non-null, only consider candidate targets in the same
|
|
|
|
// document as the exact target. Otherwise, if an ancestor document has
|
2015-07-31 13:22:46 +00:00
|
|
|
// a mouse event handler for example, targets that are !GetClickableAncestor can
|
2012-08-20 00:02:42 +00:00
|
|
|
// never be targeted --- something nsSubDocumentFrame in an ancestor document
|
|
|
|
// would be targeted instead.
|
|
|
|
nsIFrame* restrictToDescendants = target ?
|
|
|
|
target->PresContext()->PresShell()->GetRootFrame() : aRootFrame;
|
2014-01-29 13:54:25 +00:00
|
|
|
|
|
|
|
nsRect targetRect = GetTargetRect(aRootFrame, aPointRelativeToRootFrame,
|
2014-11-03 14:43:52 +00:00
|
|
|
restrictToDescendants, prefs, aFlags);
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG("Expanded point to target rect %s\n",
|
|
|
|
mozilla::layers::Stringify(targetRect).c_str());
|
2014-01-29 13:54:25 +00:00
|
|
|
nsAutoTArray<nsIFrame*,8> candidates;
|
|
|
|
nsresult rv = nsLayoutUtils::GetFramesForArea(aRootFrame, targetRect, candidates, flags);
|
|
|
|
if (NS_FAILED(rv)) {
|
|
|
|
return target;
|
|
|
|
}
|
|
|
|
|
2014-11-24 14:33:06 +00:00
|
|
|
int32_t elementsInCluster = 0;
|
|
|
|
|
2012-08-20 00:02:42 +00:00
|
|
|
nsIFrame* closestClickable =
|
2013-07-30 16:22:46 +00:00
|
|
|
GetClosest(aRootFrame, aPointRelativeToRootFrame, targetRect, prefs,
|
Bug 1181763 - Allow the target fluffing code to fluff even when directly hitting something clickable. r=roc
There is a common pattern on the web where a click listener is registered on a
container element high up in the DOM tree, and based on the target of the click
events, it performs the appropriate action. In such cases, our existing fluffing
code was not getting activated anywhere inside the container, because the entire
container was considered clickable. However, this is not user-friendly because
often the actual targets inside the container are small and hard to hit. Also,
the fluffing code will often take the container element itself as the target,
even if the user actually hit something inside the container.
This patch changes this behaviour so when an event hits inside a clickable
container, fluffing still occurs, but is restricted to DOM descendants of the
container. This allows fluffing to work in the above scenarios, and since the
events will bubble up to the container, the listeners on the container are
guaranteed to still trigger.
2015-07-17 12:36:00 +00:00
|
|
|
restrictToDescendants, clickableAncestor, candidates,
|
|
|
|
&elementsInCluster);
|
2014-11-04 14:52:16 +00:00
|
|
|
if (closestClickable) {
|
2015-05-15 20:20:12 +00:00
|
|
|
if ((!prefs->mTouchClusterDetectionDisabled && elementsInCluster > 1) ||
|
2015-02-07 11:17:12 +00:00
|
|
|
(!IsElementClickableAndReadable(closestClickable, aEvent, prefs))) {
|
2014-11-24 14:33:06 +00:00
|
|
|
if (aEvent->mClass == eMouseEventClass) {
|
|
|
|
WidgetMouseEventBase* mouseEventBase = aEvent->AsMouseEventBase();
|
|
|
|
mouseEventBase->hitCluster = true;
|
|
|
|
}
|
|
|
|
}
|
2014-11-04 14:52:16 +00:00
|
|
|
target = closestClickable;
|
|
|
|
}
|
2014-11-06 13:05:51 +00:00
|
|
|
PET_LOG("Final target is %p\n", target);
|
|
|
|
|
|
|
|
// Uncomment this to dump the frame tree to help with debugging.
|
|
|
|
// Note that dumping the frame tree at the top of the function may flood
|
|
|
|
// logcat on Android devices and cause the PET_LOGs to get dropped.
|
|
|
|
// aRootFrame->DumpFrameTree();
|
2014-11-04 14:52:16 +00:00
|
|
|
|
|
|
|
if (!target || !prefs->mRepositionEventCoords) {
|
|
|
|
// No repositioning required for this event
|
|
|
|
return target;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Take the point relative to the root frame, make it relative to the target,
|
|
|
|
// clamp it to the bounds, and then make it relative to the root frame again.
|
|
|
|
nsPoint point = aPointRelativeToRootFrame;
|
|
|
|
if (nsLayoutUtils::TRANSFORM_SUCCEEDED != nsLayoutUtils::TransformPoint(aRootFrame, target, point)) {
|
|
|
|
return target;
|
|
|
|
}
|
|
|
|
point = target->GetRectRelativeToSelf().ClampPoint(point);
|
|
|
|
if (nsLayoutUtils::TRANSFORM_SUCCEEDED != nsLayoutUtils::TransformPoint(target, aRootFrame, point)) {
|
|
|
|
return target;
|
|
|
|
}
|
|
|
|
// Now we basically undo the operations in GetEventCoordinatesRelativeTo, to
|
|
|
|
// get back the (now-clamped) coordinates in the event's widget's space.
|
|
|
|
nsView* view = aRootFrame->GetView();
|
|
|
|
if (!view) {
|
|
|
|
return target;
|
|
|
|
}
|
2015-02-04 20:21:03 +00:00
|
|
|
LayoutDeviceIntPoint widgetPoint = nsLayoutUtils::TranslateViewToWidget(
|
2014-11-04 14:52:16 +00:00
|
|
|
aRootFrame->PresContext(), view, point, aEvent->widget);
|
|
|
|
if (widgetPoint.x != NS_UNCONSTRAINEDSIZE) {
|
|
|
|
// If that succeeded, we update the point in the event
|
2015-02-04 20:21:03 +00:00
|
|
|
aEvent->refPoint = widgetPoint;
|
2014-11-04 14:52:16 +00:00
|
|
|
}
|
|
|
|
return target;
|
2012-08-20 00:02:42 +00:00
|
|
|
}
|
|
|
|
|
2015-07-13 15:25:42 +00:00
|
|
|
} // namespace mozilla
|