Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
c355a037bb
gecko-dev/.flake8

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

98 lines
3.3 KiB
Plaintext
Raw Normal View History

Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l --HG-- extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e
2016-05-05 21:21:12 +00:00
[flake8]
max-line-length = 99
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran |mach lint foo/bar|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g |mach lint foo|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running |mach lint foo/bar| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running |mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 21:32:31 +00:00
exclude =
Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao This ensures that the default for new python files is to be linted by flake8. Depends on D20496 Differential Revision: https://phabricator.services.mozilla.com/D20497 --HG-- extra : moz-landing-system : lando
2019-02-22 21:25:50 +00:00
# These paths should be triaged and either fixed or moved to the list below.
client.py,
devtools/shared,
dom/base,
dom/bindings,
dom/browser-element,
dom/canvas,
dom/encoding,
dom/imptests,
dom/security,
dom/websocket,
embedding/ios/moz.configure,
gfx/tests,
layout/base/tests/marionette,
layout/reftests/border-image,
layout/reftests/fonts,
layout/reftests/w3c-css,
layout/style,
media/libdav1d/generate_source.py,
moz.configure,
netwerk/dns/prepare_tlds.py,
netwerk/protocol/http/make_incoming_tables.py,
python/devtools/migrate-l10n/migrate/main.py,
python/l10n/fluent_migrations,
python/mozbuild,
servo/components/style,
testing/jsshell/benchmark.py,
testing/marionette/mach_commands.py,
testing/mozharness/docs,
testing/mozharness/examples,
testing/mozharness/external_tools,
testing/mozharness/mach_commands.py,
testing/mozharness/manifestparser,
testing/mozharness/mozprocess,
testing/mozharness/setup.py,
testing/parse_build_tests_ccov.py,
testing/runtimes/writeruntimes.py,
testing/tools/iceserver/iceserver.py,
testing/tools/view_gecko_profile/view_gecko_profile.py,
testing/tools/websocketprocessbridge/websocketprocessbridge.py,
testing/web-platform,
toolkit/components/featuregates,
toolkit/content/tests/chrome/file_about_networking_wsh.py,
toolkit/crashreporter/tools/symbolstore.py,
toolkit/crashreporter/tools/unit-symbolstore.py,
toolkit/library/dependentlibs.py,
toolkit/locales/generate_update_locale.py,
toolkit/mozapps,
toolkit/moz.configure,
toolkit/nss.configure,
# These paths are intentionally excluded (not necessarily for good reason).
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353 --HG-- extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
build/build-infer/build-infer.py,
Backed out changeset 4738f8111a82 (bug 1478338) for linting failure at builds/worker/checkouts/gecko/build/moz.configure/android-ndk.configure:8 on a CLOSED TREE
2018-07-25 13:56:19 +00:00
build/moz.configure/*.configure,
bug 1463425 - Add more directories to the flake8 list r=ahal MozReview-Commit-ID: JMZQonceq8W --HG-- extra : rebase_source : 1d8d0218f128dede197fa99e5cba1f0101a80384
2018-05-22 13:26:22 +00:00
build/pymake/,
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353 --HG-- extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
browser/extensions/mortar/ppapi/,
browser/moz.configure,
Bug 1468273 - Add closure-lib and intl/icu into the flake8 ignore list r=ahal MozReview-Commit-ID: A68UyXSHO9l --HG-- extra : rebase_source : 92c965aba41d31d47e437ef3e72070fe5d060338
2018-06-13 06:11:40 +00:00
dom/canvas/test/webgl-conf/checkout/closure-library/,
Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP --HG-- extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 12:13:44 +00:00
editor/libeditor/tests/browserscope/,
Bug 1468273 - Add closure-lib and intl/icu into the flake8 ignore list r=ahal MozReview-Commit-ID: A68UyXSHO9l --HG-- extra : rebase_source : 92c965aba41d31d47e437ef3e72070fe5d060338
2018-06-13 06:11:40 +00:00
intl/icu/,
Bug 1508889 - Remove ipc/chromium from the lists of third-party code. r=Ehsan The ipc/chromium tree has been forked from its former upstream and heavily modified, so it's safe to reformat and lint. However, ipc/chromium/src/third_party (a copy of libevent) is following its upstream, so that should remain exempt. Differential Revision: https://phabricator.services.mozilla.com/D12498 --HG-- extra : moz-landing-system : lando
2018-11-21 03:11:37 +00:00
ipc/chromium/src/third_party/,
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353 --HG-- extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
js/*.configure,
Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP --HG-- extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 12:13:44 +00:00
gfx/angle/,
gfx/harfbuzz,
Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao This ensures that the default for new python files is to be linted by flake8. Depends on D20496 Differential Revision: https://phabricator.services.mozilla.com/D20497 --HG-- extra : moz-landing-system : lando
2019-02-22 21:25:50 +00:00
gfx/skia/,
Bug 1473308 - [flake8] Pass custom extension list into the flake8 binary r=marco We're supposed to be linting both .py and .configure files with flake8. However we never inform flake8 of this fact. So e.g running: ./mach lint -l flake8 mobile/android Will not lint mobile/android/gradle.configure. However since flake8 will run on a file regardless of its extension if you pass that file in directly, it means that running: ./mach lint -l flake8 mobile/android/gradle.configure *Will* cause the file to be linted (and subsequently fail). This fix makes sure that flake8 knows to look at .configure files in addition to .py. Since this means many .configure files around the tree will start getting linted for the first time, we need to exclude them until they can be fixed. Differential Revision: https://phabricator.services.mozilla.com/D1975 --HG-- extra : moz-landing-system : lando
2018-07-06 12:39:39 +00:00
memory/moz.configure,
mobile/android/*.configure,
Bug 1440421 part 1. Ignore activity-stream and node_modules for linting. r=ahal MozReview-Commit-ID: EEua2y790cW --HG-- extra : rebase_source : ce98dcbd82eb1f59594d6fe40e34648b7bd639de
2018-06-06 17:32:43 +00:00
node_modules,
Bug 1464869 - Also ignore security/nss/ r=ahal MozReview-Commit-ID: 8m4CbrAaLHl --HG-- extra : rebase_source : 5643bb18d950e0d1010bea7f4a51f57195830aa9
2018-05-28 18:58:54 +00:00
security/nss/,
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354 --HG-- extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
testing/marionette/harness/marionette_harness/runner/mixins,
testing/marionette/harness/marionette_harness/tests,
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran |mach lint foo/bar|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g |mach lint foo|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running |mach lint foo/bar| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running |mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 21:32:31 +00:00
testing/mochitest/pywebsocket,
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354 --HG-- extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
testing/mozharness/configs/test/test_malformed.py,
Bug 1436802 - [lint] Add some tests for the flake8 linter integration r=andi This essentially tests tools/lint/python/flake8.py. Though it also adds a basic framework for testing all the other linters as well. Getting this added now will allow others to collaborate on adding more tests without needing to get to 100% coverage for all linters right off the bat. All python tests under tools/lint/test will run as part of the 'ml' task on Linux, and the build task on Windows (OSX coverage is currently missing for python tests). The flake8 linter currently has a bug where the 'exclude' argument is ignored. This is why we need to also exclude 'tools/lint/test/files' in topsrcdir/.flake8, even though it is already listed in the 'mach_commands.py'. Other linters shouldn't need to do this, the exclusion in 'mach_commands.py' should be good enough. See bug 1277851 for more details. MozReview-Commit-ID: 9ho8C83eeuj --HG-- extra : rebase_source : 0adb01aa81c06f26cb891ae9f92a17f8f9fdf111
2018-03-22 21:24:15 +00:00
tools/lint/test/files,
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353 --HG-- extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
tools/infer/test/*.configure,
Bug 1519307 - Add a new project to build useful parts of breakpad independently. r=froydnj With `ac_add_options --enable-project=tools/crashreporter` in a mozconfig, `./mach build` builds minidump_stackwalk, dump_syms and fileid. One caveat is that due to limitation in how the build system works currently, it's cumbersome to keep dump_syms as a host program for Gecko, and to make it a target program for this project. For now, keep it as a host program. We're not going to use it on automation, but it's still convenient to have for quick local builds (I've had to resort to awful hacks downstream). Differential Revision: https://phabricator.services.mozilla.com/D16299 --HG-- extra : moz-landing-system : lando
2019-01-11 16:01:15 +00:00
tools/crashreporter/*.configure,
Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao This ensures that the default for new python files is to be linted by flake8. Depends on D20496 Differential Revision: https://phabricator.services.mozilla.com/D20497 --HG-- extra : moz-landing-system : lando
2019-02-22 21:25:50 +00:00
.ycm_extra_conf.py,
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353 --HG-- extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
# See:
# - http://flake8.pycqa.org/en/latest/user/error-codes.html
# - http://pep8.readthedocs.io/en/latest/intro.html#configuration
ignore =
# These should be triaged and either fixed or moved to the list below.
F632, F633, F811, E117, W504, W605, W606,
# These are intentionally disabled (not necessarily for good reason).
# F723: syntax error in type comment
# text contains quotes which breaks our custom JSON formatter
F723, E121, E123, E126, E129, E133, E226, E241, E242, E402, E704, E741, W503,
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354 --HG-- extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
per-file-ignores =
ipc/ipdl/*: F403, F405
Bug 1367092 - [flake8] Use per-file-ignores to skip __init__.py files under testing/marionette and testing/firefox-ui, r=ato This allows us to only skip the "unused import" config in these files rather than the entire thing. This also removes the only two uses of "**" in the exclusion rules which made things a bit simpler for me later on in the series. Differential Revision: https://phabricator.services.mozilla.com/D20493 --HG-- extra : moz-landing-system : lando
2019-02-22 14:37:55 +00:00
testing/firefox-ui/**/__init__.py: F401
testing/marionette/**/__init__.py: F401
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354 --HG-- extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
testing/mozharness/configs/*: E124, E127, E128, E131, E231, E261, E265, E266, E501, W391
Reference in New Issue Copy Permalink