Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-03 15:26:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
gecko-dev/.flake8

25 lines
707 B
Plaintext
Raw Normal View History

Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l --HG-- extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e
2016-05-05 17:21:12 -04:00
[flake8]
Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal MozReview-Commit-ID: INBZaZzcPmF --HG-- extra : rebase_source : c0ba416f110b2768fc744de0fbee21c765081400
2016-09-28 08:28:04 -04:00
# See http://pep8.readthedocs.io/en/latest/intro.html#configuration
Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood This is a new issue that gets linted with flake8 3.5.0. Basically you should never use a blank except: statement. This will catch all exceptions, including KeyboardInterrupt and SystemExit (which is likely not intended). If a catch all is needed, use `except: Exception`. If you *really* mean to also catch KeyboardInterrupt et al, use `except: BaseException`. Of course, being specific is often better than a catch all. MozReview-Commit-ID: FKx80MLO4RN --HG-- extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741
Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l --HG-- extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e
2016-05-05 17:21:12 -04:00
max-line-length = 99
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran |mach lint foo/bar|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g |mach lint foo|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running |mach lint foo/bar| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running |mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
exclude =
bug 1463425 - Fix flake8 in browser/ r=ahal,gps MozReview-Commit-ID: 11Kil84u0TP --HG-- extra : rebase_source : f5ec701490b52bba8b45a790812025c8ab5cf963
2018-05-21 23:13:07 +02:00
browser/extensions/mortar/ppapi/,
Bug 1473308 - [flake8] Pass custom extension list into the flake8 binary r=marco We're supposed to be linting both .py and .configure files with flake8. However we never inform flake8 of this fact. So e.g running: ./mach lint -l flake8 mobile/android Will not lint mobile/android/gradle.configure. However since flake8 will run on a file regardless of its extension if you pass that file in directly, it means that running: ./mach lint -l flake8 mobile/android/gradle.configure *Will* cause the file to be linted (and subsequently fail). This fix makes sure that flake8 knows to look at .configure files in addition to .py. Since this means many .configure files around the tree will start getting linted for the first time, we need to exclude them until they can be fixed. Differential Revision: https://phabricator.services.mozilla.com/D1975 --HG-- extra : moz-landing-system : lando
2018-07-06 12:39:39 +00:00
browser/moz.configure,
Backed out changeset 4738f8111a82 (bug 1478338) for linting failure at builds/worker/checkouts/gecko/build/moz.configure/android-ndk.configure:8 on a CLOSED TREE
2018-07-25 16:56:19 +03:00
build/moz.configure/*.configure,
bug 1463425 - Add more directories to the flake8 list r=ahal MozReview-Commit-ID: JMZQonceq8W --HG-- extra : rebase_source : 1d8d0218f128dede197fa99e5cba1f0101a80384
2018-05-22 06:26:22 -07:00
build/pymake/,
Bug 1468273 - Add closure-lib and intl/icu into the flake8 ignore list r=ahal MozReview-Commit-ID: A68UyXSHO9l --HG-- extra : rebase_source : 92c965aba41d31d47e437ef3e72070fe5d060338
2018-06-12 23:11:40 -07:00
dom/canvas/test/webgl-conf/checkout/closure-library/,
Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP --HG-- extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 14:13:44 +02:00
editor/libeditor/tests/browserscope/,
Bug 1468273 - Add closure-lib and intl/icu into the flake8 ignore list r=ahal MozReview-Commit-ID: A68UyXSHO9l --HG-- extra : rebase_source : 92c965aba41d31d47e437ef3e72070fe5d060338
2018-06-12 23:11:40 -07:00
intl/icu/,
Bug 1468273 - Ignore ipc/chromium r=ahal MozReview-Commit-ID: HhXbRSMrTLP --HG-- extra : rebase_source : 817f9a42af334bdeb73a091468d81fe0d06501a0
2018-06-11 17:31:33 -07:00
ipc/chromium/,
Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP --HG-- extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 14:13:44 +02:00
gfx/angle/,
gfx/harfbuzz,
glx/skia/,
Bug 1473308 - [flake8] Pass custom extension list into the flake8 binary r=marco We're supposed to be linting both .py and .configure files with flake8. However we never inform flake8 of this fact. So e.g running: ./mach lint -l flake8 mobile/android Will not lint mobile/android/gradle.configure. However since flake8 will run on a file regardless of its extension if you pass that file in directly, it means that running: ./mach lint -l flake8 mobile/android/gradle.configure *Will* cause the file to be linted (and subsequently fail). This fix makes sure that flake8 knows to look at .configure files in addition to .py. Since this means many .configure files around the tree will start getting linted for the first time, we need to exclude them until they can be fixed. Differential Revision: https://phabricator.services.mozilla.com/D1975 --HG-- extra : moz-landing-system : lando
2018-07-06 12:39:39 +00:00
js/*.configure,
memory/moz.configure,
mobile/android/*.configure,
Bug 1440421 part 1. Ignore activity-stream and node_modules for linting. r=ahal MozReview-Commit-ID: EEua2y790cW --HG-- extra : rebase_source : ce98dcbd82eb1f59594d6fe40e34648b7bd639de
2018-06-06 10:32:43 -07:00
node_modules,
Bug 1464869 - Also ignore security/nss/ r=ahal MozReview-Commit-ID: 8m4CbrAaLHl --HG-- extra : rebase_source : 5643bb18d950e0d1010bea7f4a51f57195830aa9
2018-05-28 20:58:54 +02:00
security/nss/,
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran |mach lint foo/bar|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g |mach lint foo|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running |mach lint foo/bar| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running |mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
testing/mochitest/pywebsocket,
Bug 1436802 - [lint] Add some tests for the flake8 linter integration r=andi This essentially tests tools/lint/python/flake8.py. Though it also adds a basic framework for testing all the other linters as well. Getting this added now will allow others to collaborate on adding more tests without needing to get to 100% coverage for all linters right off the bat. All python tests under tools/lint/test will run as part of the 'ml' task on Linux, and the build task on Windows (OSX coverage is currently missing for python tests). The flake8 linter currently has a bug where the 'exclude' argument is ignored. This is why we need to also exclude 'tools/lint/test/files' in topsrcdir/.flake8, even though it is already listed in the 'mach_commands.py'. Other linters shouldn't need to do this, the exclusion in 'mach_commands.py' should be good enough. See bug 1277851 for more details. MozReview-Commit-ID: 9ho8C83eeuj --HG-- extra : rebase_source : 0adb01aa81c06f26cb891ae9f92a17f8f9fdf111
2018-03-22 17:24:15 -04:00
tools/lint/test/files,
Bug 1473951: Add infer to taskcluster and build. r=gps MozReview-Commit-ID: BHi3E6J3nuH --HG-- extra : rebase_source : a59180efe4fed56222d2847d60133739f38c8ca8
2018-07-06 17:37:16 +01:00
build/build-infer/build-infer.py,
Reference in New Issue Copy Permalink