2013-10-14 15:28:11 +00:00
|
|
|
# Contributing to Servo
|
|
|
|
|
|
|
|
|
|
Servo welcomes contribution from everyone. Here are the guidelines if you are
|
|
|
|
|
thinking of helping us:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
## Contributions
|
|
|
|
|
|
|
|
|
|
Contributions to Servo or its dependencies should be made in the form of GitHub
|
|
|
|
|
pull requests. Each pull request will be reviewed by a core contributor
|
|
|
|
|
(someone with permission to land patches) and either landed in the main tree or
|
|
|
|
|
given feedback for changes that would be required. All contributions should
|
|
|
|
|
follow this format, even those from core contributors.
|
|
|
|
|
|
2015-04-30 18:00:42 +00:00
|
|
|
If you're looking for easy bugs, have a look at the [E-Easy issue tag](https://github.com/servo/servo/labels/E-easy) on GitHub.
|
2013-10-14 15:28:11 +00:00
|
|
|
|
|
|
|
|
## Pull Request Checklist
|
|
|
|
|
|
|
|
|
|
- Branch from the master branch and, if needed, rebase to the current master
|
|
|
|
|
branch before submitting your pull request. If it doesn't merge cleanly with
|
|
|
|
|
master you may be asked to rebase your changes.
|
|
|
|
|
|
|
|
|
|
- Don't put submodule updates in your pull request unless they are to landed
|
|
|
|
|
commits.
|
|
|
|
|
|
|
|
|
|
- If your patch is not getting reviewed or you need a specific person to review
|
|
|
|
|
it, you can @-reply a reviewer asking for a review in the pull request or a
|
|
|
|
|
comment, or you can ask for a review in `#servo` on `irc.mozilla.org`.
|
|
|
|
|
|
2014-03-08 00:19:24 +00:00
|
|
|
- Add tests relevant to the fixed bug or new feature. For a DOM change this
|
2015-04-16 10:41:56 +00:00
|
|
|
will usually be a web platform test; for layout, a reftest. See our [testing
|
2015-04-30 18:00:42 +00:00
|
|
|
guide](https://github.com/servo/servo/wiki/Testing) for more information.
|
2013-10-14 15:28:11 +00:00
|
|
|
|
2015-09-18 15:48:21 +00:00
|
|
|
For specific git instructions, see [GitHub workflow 101](https://github.com/servo/servo/wiki/Github-workflow).
|
2013-10-14 15:28:11 +00:00
|
|
|
|
|
|
|
|
## Conduct
|
|
|
|
|
|
2015-04-08 04:55:31 +00:00
|
|
|
We follow the [Rust Code of Conduct](http://www.rust-lang.org/conduct.html).
|
2013-10-14 15:28:11 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
## Communication
|
|
|
|
|
|
|
|
|
|
Servo contributors frequent the `#servo` channel on [`irc.mozilla.org`](https://wiki.mozilla.org/IRC).
|
|
|
|
|
|
|
|
|
|
You can also join the [`dev-servo` mailing list](https://lists.mozilla.org/listinfo/dev-servo).
|
