Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 05:11:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
e26c0f92a0
gecko-dev/pyproject.toml

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

134 lines
4.8 KiB
TOML
Raw Normal View History

Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
[tool.ruff]
line-length = 99
# See https://beta.ruff.rs/docs/rules/ for a full list of rules.
select = [
"E", "W", # pycodestyle
"F", # pyflakes
Bug 1811850 - [lint] Replace isort linter with ruff, r=taskgraph-reviewers,linter-reviewers,marco,jcristau This results in some changes from our current `isort` configuration. I'm unclear if it's because ruff isn't at 100% parity with isort, they choose different defaults or if I missed some configuration. Either way, the changes all look reasonable to me (see child commit), so I'm inclined to just accept the new import format it imposes. Differential Revision: https://phabricator.services.mozilla.com/D172348
2023-03-20 13:06:27 +00:00
"I", # isort
Bug 1811850 - [lint] Replace pylint linter with ruff, r=linter-reviewers,marco This is enabling the PLE and PLC rules across a much larger swatch of the code base. The PLR and PLW are additionally enabled at the warning level (introduces ~2500 new warnings). To avoid extraneous changes in people's patches, rules at the warning level are excluded from --fix. Differential Revision: https://phabricator.services.mozilla.com/D172358
2023-03-20 13:06:28 +00:00
"PL", # pylint
Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
]
ignore = [
# These should be triaged and either fixed or moved to the list below.
Bug 1879558 - Reactivate invalid escape sequence warning in ruff r=ahochheiden Differential Revision: https://phabricator.services.mozilla.com/D201220
2024-02-28 08:16:06 +00:00
"E713", "E714",
Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
Bug 1823694 - [lint.ruff] Disable some warnings we don't actually want to enforce, r=linter-reviewers,andi This disables: PLR0911 too-many-return-statements PLR0912 too-many-branches PLR0913 too-many-arguments PLR0914 too-many-return-statements PLR2004 magic-value-comparison This removes nearly 2000 warnings. Differential Revision: https://phabricator.services.mozilla.com/D173156
2023-03-21 14:36:26 +00:00
# These are intentionally ignored.
"E741", # ambiguous-variable-name
"PLR09", # too-many-return-statements, too-many-branches, too-many-arguments, too-many-statements
"PLR2004", # magic-value-comparison
Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
# These are handled by black.
"E1", "E4", "E5", "W2", "W5"
]
builtins = ["gdb"]
exclude = [
# These paths should be triaged and either fixed or moved to the list below.
"devtools/shared",
"dom/bindings/Codegen.py",
"dom/bindings/parser/WebIDL.py",
"dom/bindings/parser/tests/test_arraybuffer.py",
"dom/bindings/parser/tests/test_securecontext_extended_attribute.py",
"gfx/tests",
"ipc/ipdl/ipdl",
"layout/base/tests/marionette",
"layout/reftests/border-image",
"layout/reftests/fonts",
"layout/reftests/w3c-css",
"layout/style",
"media/libdav1d/generate_source.py",
"moz.configure",
"netwerk/dns/prepare_tlds.py",
"netwerk/protocol/http/make_incoming_tables.py",
"python/l10n/fluent_migrations",
"security/manager/ssl/tests/unit",
"servo/components/style",
"testing/condprofile/condprof/android.py",
"testing/condprofile/condprof/creator.py",
"testing/condprofile/condprof/desktop.py",
"testing/condprofile/condprof/runner.py",
"testing/condprofile/condprof/scenarii/heavy.py",
"testing/condprofile/condprof/scenarii/settled.py",
"testing/condprofile/condprof/scenarii/synced.p",
"testing/condprofile/condprof/helpers.py",
"testing/jsshell/benchmark.py",
"testing/marionette/mach_commands.py",
"testing/mozharness/docs",
"testing/mozharness/examples",
"testing/mozharness/external_tools",
"testing/mozharness/mach_commands.py",
"testing/mozharness/manifestparser",
"testing/mozharness/mozprocess",
"testing/mozharness/setup.py",
"testing/parse_build_tests_ccov.py",
"testing/runtimes/writeruntimes.py",
"testing/tools/iceserver/iceserver.py",
"testing/tools/websocketprocessbridge/websocketprocessbridge.py",
"toolkit/components/featuregates",
"toolkit/content/tests/chrome/file_about_networking_wsh.py",
"toolkit/library/build/dependentlibs.py",
"toolkit/locales/generate_update_locale.py",
"toolkit/mozapps",
"toolkit/moz.configure",
"toolkit/nss.configure",
# mako files are not really python files
"*.mako.py",
# These paths are intentionally excluded (not necessarily for good reason).
"build/moz.configure/*.configure",
"build/pymake/",
"browser/extensions/mortar/ppapi/",
"browser/moz.configure",
"dom/canvas/test/webgl-conf/checkout/closure-library/",
"editor/libeditor/tests/browserscope/",
"intl/icu/",
"ipc/chromium/src/third_party/",
"js/*.configure",
"gfx/angle/",
"gfx/harfbuzz",
"gfx/skia/",
"memory/moz.configure",
"mobile/android/*.configure",
"node_modules",
"python/mozbuild/mozbuild/test/configure/data",
"security/nss/",
"testing/marionette/harness/marionette_harness/runner/mixins",
"testing/marionette/harness/marionette_harness/tests",
"testing/mochitest/pywebsocket3",
"testing/mozharness/configs/test/test_malformed.py",
"testing/web-platform/tests",
"tools/lint/test/files",
"tools/crashreporter/*.configure",
".ycm_extra_conf.py",
]
[tool.ruff.per-file-ignores]
# These paths are intentionally excluded.
Bug 1811850 - [lint] Replace pylint linter with ruff, r=linter-reviewers,marco This is enabling the PLE and PLC rules across a much larger swatch of the code base. The PLR and PLW are additionally enabled at the warning level (introduces ~2500 new warnings). To avoid extraneous changes in people's patches, rules at the warning level are excluded from --fix. Differential Revision: https://phabricator.services.mozilla.com/D172358
2023-03-20 13:06:28 +00:00
"dom/bindings/Configuration.py" = ["PLC3002"]
Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
"ipc/ipdl/*" = ["F403", "F405"]
"layout/tools/reftest/selftest/conftest.py" = ["F811"]
# cpp_eclipse has a lot of multi-line embedded XML which exceeds line length
"python/mozbuild/mozbuild/backend/cpp_eclipse.py" = ["E501"]
"testing/firefox-ui/**/__init__.py" = ["F401"]
"testing/marionette/**/__init__.py" = ["F401"]
"testing/mochitest/tests/python/conftest.py" = ["F811"]
"testing/mozbase/manifestparser/tests/test_filters.py" = ["E731"]
Bug 1811850 - [lint] Replace pylint linter with ruff, r=linter-reviewers,marco This is enabling the PLE and PLC rules across a much larger swatch of the code base. The PLR and PLW are additionally enabled at the warning level (introduces ~2500 new warnings). To avoid extraneous changes in people's patches, rules at the warning level are excluded from --fix. Differential Revision: https://phabricator.services.mozilla.com/D172358
2023-03-20 13:06:28 +00:00
"testing/mozbase/mozinfo/mozinfo/mozinfo.py" = ["PLE0605"]
Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-20 13:06:27 +00:00
"testing/mozbase/mozlog/tests/test_formatters.py" = ["E501"]
"testing/mozharness/configs/*" = ["E501"]
"**/*.configure" = ["F821"]
# These paths contain Python-2 only syntax.
"build/compare-mozconfig/compare-mozconfigs.py" = ["F821"]
"build/midl.py" = ["F821"]
"build/pgo/genpgocert.py" = ["F821"]
"config/MozZipFile.py" = ["F821"]
"config/check_source_count.py" = ["F821"]
"config/tests/unitMozZipFile.py" = ["F821"]
"ipc/pull-chromium.py" = ["F633"]
"js/src/**" = ["F633", "F821"]
"python/mozbuild/mozbuild/action/dump_env.py" = ["F821"]
"python/mozbuild/mozbuild/dotproperties.py" = ["F821"]
"python/mozbuild/mozbuild/testing.py" = ["F821"]
"python/mozbuild/mozbuild/util.py" = ["F821"]
"testing/mozharness/mozharness/mozilla/testing/android.py" = ["F821"]
"testing/mochitest/runtests.py" = ["F821"]
Reference in New Issue Copy Permalink