gecko-dev/servo/CONTRIBUTING.md

46 lines
1.9 KiB
Markdown
Raw Normal View History

# Contributing to Servo
Servo welcomes contribution from everyone. Here are the guidelines if you are
thinking of helping us:
## Contributions
Contributions to Servo or its dependencies should be made in the form of GitHub
pull requests. Each pull request will be reviewed by a core contributor
(someone with permission to land patches) and either landed in the main tree or
given feedback for changes that would be required. All contributions should
follow this format, even those from core contributors.
If you're looking for easy bugs, have a look at the [E-Easy issue tag](https://github.com/mozilla/servo/issues?labels=E-easy&page=1&state=open) on GitHub.
## Pull Request Checklist
- Branch from the master branch and, if needed, rebase to the current master
branch before submitting your pull request. If it doesn't merge cleanly with
master you may be asked to rebase your changes.
- Don't put submodule updates in your pull request unless they are to landed
commits.
- If your patch is not getting reviewed or you need a specific person to review
it, you can @-reply a reviewer asking for a review in the pull request or a
comment, or you can ask for a review in `#servo` on `irc.mozilla.org`.
servo: Merge #1859 - Move content tests to src/test/content for consistency (from kmcallister:move); r=jdm And update `CONTRIBUTING.md`. Source-Repo: https://github.com/servo/servo Source-Revision: d79c8a10cfd07be712826d831394814cdfec71af --HG-- rename : servo/src/test/html/content/harness.js => servo/src/test/content/harness.js rename : servo/src/test/html/content/test.jpg => servo/src/test/content/test.jpg rename : servo/src/test/html/content/test.png => servo/src/test/content/test.png rename : servo/src/test/html/content/test_DOMParser.html => servo/src/test/content/test_DOMParser.html rename : servo/src/test/html/content/test_Event.html => servo/src/test/content/test_Event.html rename : servo/src/test/html/content/test_MouseEvent.html => servo/src/test/content/test_MouseEvent.html rename : servo/src/test/html/content/test_childnodes.html => servo/src/test/content/test_childnodes.html rename : servo/src/test/html/content/test_collections.html => servo/src/test/content/test_collections.html rename : servo/src/test/html/content/test_create_element.html => servo/src/test/content/test_create_element.html rename : servo/src/test/html/content/test_documentElement.html => servo/src/test/content/test_documentElement.html rename : servo/src/test/html/content/test_document_body.html => servo/src/test/content/test_document_body.html rename : servo/src/test/html/content/test_document_characterSet.html => servo/src/test/content/test_document_characterSet.html rename : servo/src/test/html/content/test_document_characterSet_default.html => servo/src/test/content/test_document_characterSet_default.html rename : servo/src/test/html/content/test_document_characterSet_invalid.html => servo/src/test/content/test_document_characterSet_invalid.html rename : servo/src/test/html/content/test_document_characterSet_long.html => servo/src/test/content/test_document_characterSet_long.html rename : servo/src/test/html/content/test_document_characterSet_short.html => servo/src/test/content/test_document_characterSet_short.html rename : servo/src/test/html/content/test_document_compatMode.html => servo/src/test/content/test_document_compatMode.html rename : servo/src/test/html/content/test_document_compatMode_loose.html => servo/src/test/content/test_document_compatMode_loose.html rename : servo/src/test/html/content/test_document_compatMode_strict.html => servo/src/test/content/test_document_compatMode_strict.html rename : servo/src/test/html/content/test_document_contenttype.html => servo/src/test/content/test_document_contenttype.html rename : servo/src/test/html/content/test_document_createProcessingInstruction.html => servo/src/test/content/test_document_createProcessingInstruction.html rename : servo/src/test/html/content/test_document_doctype.html => servo/src/test/content/test_document_doctype.html rename : servo/src/test/html/content/test_document_getElementById.html => servo/src/test/content/test_document_getElementById.html rename : servo/src/test/html/content/test_document_getElementsByName.html => servo/src/test/content/test_document_getElementsByName.html rename : servo/src/test/html/content/test_document_head.html => servo/src/test/content/test_document_head.html rename : servo/src/test/html/content/test_document_implementation.html => servo/src/test/content/test_document_implementation.html rename : servo/src/test/html/content/test_document_set_node_value.html => servo/src/test/content/test_document_set_node_value.html rename : servo/src/test/html/content/test_document_title_nontextchildren.html => servo/src/test/content/test_document_title_nontextchildren.html rename : servo/src/test/html/content/test_document_url.html => servo/src/test/content/test_document_url.html rename : servo/src/test/html/content/test_element_attribute.html => servo/src/test/content/test_element_attribute.html rename : servo/src/test/html/content/test_element_attributes.html => servo/src/test/content/test_element_attributes.html rename : servo/src/test/html/content/test_empty_clientrect.html => servo/src/test/content/test_empty_clientrect.html rename : servo/src/test/html/content/test_event_dispatch.html => servo/src/test/content/test_event_dispatch.html rename : servo/src/test/html/content/test_event_dispatch_dynamic.html => servo/src/test/content/test_event_dispatch_dynamic.html rename : servo/src/test/html/content/test_event_dispatch_order.html => servo/src/test/content/test_event_dispatch_order.html rename : servo/src/test/html/content/test_event_listener.html => servo/src/test/content/test_event_listener.html rename : servo/src/test/html/content/test_exception.html => servo/src/test/content/test_exception.html rename : servo/src/test/html/content/test_getBoundingClientRect.html => servo/src/test/content/test_getBoundingClientRect.html rename : servo/src/test/html/content/test_getElementsByTagName.html => servo/src/test/content/test_getElementsByTagName.html rename : servo/src/test/html/content/test_global.html => servo/src/test/content/test_global.html rename : servo/src/test/html/content/test_htmlcollection.html => servo/src/test/content/test_htmlcollection.html rename : servo/src/test/html/content/test_img_width_height.html => servo/src/test/content/test_img_width_height.html rename : servo/src/test/html/content/test_innerHTML.html => servo/src/test/content/test_innerHTML.html rename : servo/src/test/html/content/test_load_event.html => servo/src/test/content/test_load_event.html rename : servo/src/test/html/content/test_mainelement.html => servo/src/test/content/test_mainelement.html rename : servo/src/test/html/content/test_navigator.html => servo/src/test/content/test_navigator.html rename : servo/src/test/html/content/test_node_contains.html => servo/src/test/content/test_node_contains.html rename : servo/src/test/html/content/test_node_insertBefore.html => servo/src/test/content/test_node_insertBefore.html rename : servo/src/test/html/content/test_node_isEqualNode.html => servo/src/test/content/test_node_isEqualNode.html rename : servo/src/test/html/content/test_node_replaceChild.html => servo/src/test/content/test_node_replaceChild.html rename : servo/src/test/html/content/test_parentnodes.html => servo/src/test/content/test_parentnodes.html rename : servo/src/test/html/content/test_prototypes.html => servo/src/test/content/test_prototypes.html rename : servo/src/test/html/content/test_proxy_setter.html => servo/src/test/content/test_proxy_setter.html rename : servo/src/test/html/content/test_script_src_attribute.html => servo/src/test/content/test_script_src_attribute.html rename : servo/src/test/html/content/test_textcontent.html => servo/src/test/content/test_textcontent.html rename : servo/src/test/html/content/test_title.html => servo/src/test/content/test_title.html rename : servo/src/test/html/content/test_union.html => servo/src/test/content/test_union.html rename : servo/src/test/html/content/test_window.html => servo/src/test/content/test_window.html
2014-03-08 00:19:24 +00:00
- Add tests relevant to the fixed bug or new feature. For a DOM change this
will usually be a content test; for layout, a reftest. See our [testing
guide](https://github.com/mozilla/servo/wiki/Testing) for more information.
For specific git instructions, see [GitHub & Critic PR handling 101](https://github.com/mozilla/servo/wiki/Github-&-Critic-PR-handling-101).
## Conduct
We follow the [Rust Code of Conduct](https://github.com/mozilla/rust/wiki/Note-development-policy#wiki-conduct).
## Communication
Servo contributors frequent the `#servo` channel on [`irc.mozilla.org`](https://wiki.mozilla.org/IRC).
You can also join the [`dev-servo` mailing list](https://lists.mozilla.org/listinfo/dev-servo).