From 00717ee390f0f9e821168c24b051a731bda668c1 Mon Sep 17 00:00:00 2001 From: Julian Descottes Date: Tue, 6 Jun 2023 10:19:35 +0000 Subject: [PATCH] Bug 1836926 - [bidi] Rename originTime to timeOrigin in network events fetchTimingInfo r=webdriver-reviewers,whimboo We misnamed this field in the initial implementation, so this makes it consistent with the spec at https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo Differential Revision: https://phabricator.services.mozilla.com/D180064 --- .../listeners/NetworkEventRecord.sys.mjs | 32 +++++++++---------- .../modules/root/network.sys.mjs | 2 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/remote/shared/listeners/NetworkEventRecord.sys.mjs b/remote/shared/listeners/NetworkEventRecord.sys.mjs index cc3e0d100147..c38b642050a1 100644 --- a/remote/shared/listeners/NetworkEventRecord.sys.mjs +++ b/remote/shared/listeners/NetworkEventRecord.sys.mjs @@ -335,25 +335,25 @@ export class NetworkEventRecord { domainLookupStartTime; // Bug 1805478: Per spec, the origin time should match Performance API's - // originTime for the global which initiated the request. This is not + // timeOrigin for the global which initiated the request. This is not // available in the parent process, so for now we will use 0. - const originTime = 0; + const timeOrigin = 0; return { - originTime, - requestTime: this.#convertTimestamp(channelCreationTime, originTime), - redirectStart: this.#convertTimestamp(redirectStartTime, originTime), - redirectEnd: this.#convertTimestamp(redirectEndTime, originTime), - fetchStart: this.#convertTimestamp(fetchStartTime, originTime), - dnsStart: this.#convertTimestamp(domainLookupStartTime, originTime), - dnsEnd: this.#convertTimestamp(domainLookupEndTime, originTime), - connectStart: this.#convertTimestamp(connectStartTime, originTime), - connectEnd: this.#convertTimestamp(connectEndTime, originTime), - tlsStart: this.#convertTimestamp(secureConnectionStartTime, originTime), - tlsEnd: this.#convertTimestamp(connectEndTime, originTime), - requestStart: this.#convertTimestamp(requestStartTime, originTime), - responseStart: this.#convertTimestamp(responseStartTime, originTime), - responseEnd: this.#convertTimestamp(responseEndTime, originTime), + timeOrigin, + requestTime: this.#convertTimestamp(channelCreationTime, timeOrigin), + redirectStart: this.#convertTimestamp(redirectStartTime, timeOrigin), + redirectEnd: this.#convertTimestamp(redirectEndTime, timeOrigin), + fetchStart: this.#convertTimestamp(fetchStartTime, timeOrigin), + dnsStart: this.#convertTimestamp(domainLookupStartTime, timeOrigin), + dnsEnd: this.#convertTimestamp(domainLookupEndTime, timeOrigin), + connectStart: this.#convertTimestamp(connectStartTime, timeOrigin), + connectEnd: this.#convertTimestamp(connectEndTime, timeOrigin), + tlsStart: this.#convertTimestamp(secureConnectionStartTime, timeOrigin), + tlsEnd: this.#convertTimestamp(connectEndTime, timeOrigin), + requestStart: this.#convertTimestamp(requestStartTime, timeOrigin), + responseStart: this.#convertTimestamp(responseStartTime, timeOrigin), + responseEnd: this.#convertTimestamp(responseEndTime, timeOrigin), }; } diff --git a/remote/webdriver-bidi/modules/root/network.sys.mjs b/remote/webdriver-bidi/modules/root/network.sys.mjs index b44f20e58fb3..5c9b3352fa4c 100644 --- a/remote/webdriver-bidi/modules/root/network.sys.mjs +++ b/remote/webdriver-bidi/modules/root/network.sys.mjs @@ -39,7 +39,7 @@ ChromeUtils.defineESModuleGetters(lazy, { /** * @typedef {object} FetchTimingInfo - * @property {number} originTime + * @property {number} timeOrigin * @property {number} requestTime * @property {number} redirectStart * @property {number} redirectEnd