Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 21:01:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1777919 [Wayland] Don't crash on bogus move-to-rect callback r=emilio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D153580
This commit is contained in:
stransky 2022-08-03 12:09:01 +00:00
parent 51ffb2fe73
commit 0165f1f5eb
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
widget/gtk/nsWindow.cpp
View File

@ -1859,11 +1859,16 @@ void nsWindow::WaylandPopupPropagateChangesToLayout(bool aMove, bool aResize) {
void nsWindow::NativeMoveResizeWaylandPopupCallback(
const GdkRectangle* aFinalSize, bool aFlippedX, bool aFlippedY) {
#ifdef NIGHTLY_BUILD
// We're getting move-to-rect callback without move-to-rect call.
// That indicates a compositor bug
MOZ_DIAGNOSTIC_ASSERT(mWaitingForMoveToRectCallback,
"Bogus move-to-rect callback! A compositor bug?");
// That indicates a compositor bug. It happens when a window is hidden and
// shown again before move-to-rect callback is fired.
// It may lead to incorrect popup placement as we may call
// gtk_window_move() between hide & show.
// See Bug 1777919.
#if MOZ_LOGGING
if (!mWaitingForMoveToRectCallback) {
LOG(" Bogus move-to-rect callback! A compositor bug?");
}
#endif
mWaitingForMoveToRectCallback = false;