mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-02 01:48:05 +00:00
bug 809978: retry link I/O on potential race conditions
This commit is contained in:
Joey Armstrong
parent
a8d771e490
commit
02436daef9
@ -1362,13 +1362,18 @@ $(XPIDL_GEN_DIR)/%.xpt: %.idl $(XPIDL_DEPS) $(xpidl-preqs)
|
||||
|
||||
# no need to link together if XPIDLSRCS contains only XPIDL_MODULE
|
||||
ifneq ($(XPIDL_MODULE).idl,$(strip $(XPIDLSRCS)))
|
||||
XPT_PY = $(filter %/xpt.py,$(XPIDL_LINK))
|
||||
|
||||
# based on $(XPIDL_LINK)
|
||||
XPT_PY ?= $(PYTHON) $(LIBXUL_DIST)/sdk/bin/xpt.py
|
||||
|
||||
# Workaround race condition until deps fixed
|
||||
XPT_ARGS := --workaround-bug-754358
|
||||
|
||||
xpidl-idl2xpt = $(patsubst %.idl,$(XPIDL_GEN_DIR)/%.xpt,$(XPIDLSRCS))
|
||||
xpidl-module-deps = $(xpidl-idl2xpt) $(GLOBAL_DEPS) $(XPT_PY)
|
||||
|
||||
$(XPIDL_GEN_DIR)/$(XPIDL_MODULE).xpt: $(xpidl-module-deps)
|
||||
$(XPIDL_LINK) $@ $(xpidl-idl2xpt)
|
||||
$(XPT_PY) $(XPT_ARGS) link $@ $(xpidl-idl2xpt)
|
||||
|
||||
$(XPT_PY):
|
||||
$(MAKE) -C $(DEPTH)/xpcom/typelib/xpt/tools libs
|
||||
|
||||
@ -1362,13 +1362,16 @@ $(XPIDL_GEN_DIR)/%.xpt: %.idl $(XPIDL_DEPS) $(xpidl-preqs)
|
||||
|
||||
# no need to link together if XPIDLSRCS contains only XPIDL_MODULE
|
||||
ifneq ($(XPIDL_MODULE).idl,$(strip $(XPIDLSRCS)))
|
||||
XPT_PY = $(filter %/xpt.py,$(XPIDL_LINK))
|
||||
XPT_PY ?= $(PYTHON) $(LIBXUL_DIST)/sdk/bin/xpt.py
|
||||
|
||||
# Workaround race condition until deps fixed
|
||||
XPT_ARGS := --workaround-bug-754358
|
||||
|
||||
xpidl-idl2xpt = $(patsubst %.idl,$(XPIDL_GEN_DIR)/%.xpt,$(XPIDLSRCS))
|
||||
xpidl-module-deps = $(xpidl-idl2xpt) $(GLOBAL_DEPS) $(XPT_PY)
|
||||
|
||||
$(XPIDL_GEN_DIR)/$(XPIDL_MODULE).xpt: $(xpidl-module-deps)
|
||||
$(XPIDL_LINK) $@ $(xpidl-idl2xpt)
|
||||
$(XPT_PY) $(XPT_ARGS) link $@ $(xpidl-idl2xpt)
|
||||
|
||||
$(XPT_PY):
|
||||
$(MAKE) -C $(DEPTH)/xpcom/typelib/xpt/tools libs
|
||||
|
||||
179
xpcom/typelib/xpt/tools/xpt.py
Normal file → Executable file
179
xpcom/typelib/xpt/tools/xpt.py
Normal file → Executable file
@ -1011,6 +1011,7 @@ class Typelib(object):
|
||||
or the static Typelib.read method may be called to read one from a file.
|
||||
|
||||
"""
|
||||
|
||||
_header = struct.Struct(">16sBBHIII")
|
||||
|
||||
def __init__(self, version=TYPELIB_VERSION, interfaces=[], annotations=[]):
|
||||
@ -1023,6 +1024,24 @@ class Typelib(object):
|
||||
self.annotations = list(annotations)
|
||||
self.filename = None
|
||||
|
||||
@staticmethod
|
||||
def workaround_bug_754358(val=False, set=False):
|
||||
"""
|
||||
get/set function to enable race condition workaround.
|
||||
Static func helps avoid global var use.
|
||||
|
||||
"""
|
||||
if set:
|
||||
Typelib._workaround_bug_754358 = val;
|
||||
|
||||
try:
|
||||
flag = Typelib._workaround_bug_754358
|
||||
except Exception as e:
|
||||
Typelib._workaround_bug_754358 = False
|
||||
flag = Typelib._workaround_bug_754358
|
||||
|
||||
return flag
|
||||
|
||||
@staticmethod
|
||||
def iid_to_string(iid):
|
||||
"""
|
||||
@ -1065,22 +1084,67 @@ class Typelib(object):
|
||||
filename = ""
|
||||
data = None
|
||||
expected_size = None
|
||||
if isinstance(input_file, basestring):
|
||||
filename = input_file
|
||||
with open(input_file, "rb") as f:
|
||||
st = os.fstat(f.fileno())
|
||||
data = f.read(st.st_size)
|
||||
expected_size = st.st_size
|
||||
else:
|
||||
data = input_file.read()
|
||||
|
||||
(magic,
|
||||
major_ver,
|
||||
minor_ver,
|
||||
num_interfaces,
|
||||
file_length,
|
||||
interface_directory_offset,
|
||||
data_pool_offset) = Typelib._header.unpack(data[:Typelib._header.size])
|
||||
if hasattr(input_file, 'tell'):
|
||||
offset = input_file.tell()
|
||||
else:
|
||||
offset = None
|
||||
|
||||
# Correct race condition fallout ?
|
||||
workaround_bug_754358 = Typelib.workaround_bug_754358();
|
||||
|
||||
for attempt in reversed(range(12)):
|
||||
|
||||
if isinstance(input_file, basestring):
|
||||
filename = input_file
|
||||
with open(input_file, "rb") as f:
|
||||
st = os.fstat(f.fileno())
|
||||
data = f.read(st.st_size)
|
||||
expected_size = st.st_size
|
||||
else:
|
||||
if offset:
|
||||
input_file.seek(offset)
|
||||
data = input_file.read()
|
||||
|
||||
try:
|
||||
(magic,
|
||||
major_ver,
|
||||
minor_ver,
|
||||
num_interfaces,
|
||||
file_length,
|
||||
interface_directory_offset,
|
||||
data_pool_offset) = Typelib._header.unpack(data[:Typelib._header.size])
|
||||
break
|
||||
|
||||
#############################################################################
|
||||
# --workaround-bug-754358:
|
||||
# struct.error: unpack requires a string argument of length 32
|
||||
# If a very specific error occured, retry on potential race condition
|
||||
# file size is 0 - touch/exists at start of read but content not yet on disk.
|
||||
#############################################################################
|
||||
except struct.error as err:
|
||||
|
||||
if (workaround_bug_754358
|
||||
and attempt
|
||||
and len(sys.argv) > 1
|
||||
and sys.argv[1] == 'link'
|
||||
and len(err.args) > 0
|
||||
and err.args[0].startswith('unpack requires a string argument of length')
|
||||
):
|
||||
|
||||
import time
|
||||
now = time.time()
|
||||
mtime = os.path.getmtime(input_file)
|
||||
delta = abs(now - mtime)
|
||||
|
||||
# Only consider if recently modified
|
||||
if 10 > (delta / 60):
|
||||
time.sleep(5)
|
||||
continue
|
||||
|
||||
# re-raise the original error
|
||||
raise Exception("%s (source: %s)" % (err, input_file))
|
||||
|
||||
if magic != XPT_MAGIC:
|
||||
raise FileFormatError, "Bad magic: %s" % magic
|
||||
xpt = Typelib((major_ver, minor_ver))
|
||||
@ -1372,12 +1436,81 @@ def xpt_link(inputs):
|
||||
interfaces.sort()
|
||||
return Typelib(interfaces=interfaces)
|
||||
|
||||
if __name__ == '__main__':
|
||||
if len(sys.argv) < 3:
|
||||
print >>sys.stderr, "xpt <dump|link> <files>"
|
||||
sys.exit(1)
|
||||
if sys.argv[1] == 'dump':
|
||||
xpt_dump(sys.argv[2])
|
||||
elif sys.argv[1] == 'link':
|
||||
xpt_link(sys.argv[3:]).write(sys.argv[2])
|
||||
|
||||
def local_argparse():
|
||||
"""
|
||||
Use argparse to parse & validate command line args.
|
||||
A dictionary of values will be returned.
|
||||
|
||||
"""
|
||||
argv = {'dumpfile': False,
|
||||
'linkfile': False,
|
||||
'linkargs': [],
|
||||
}
|
||||
|
||||
# Morph legacy args [dump|link] into [--dump|--link]
|
||||
for i in range(1, len(sys.argv)):
|
||||
if sys.argv[i].startswith('-'):
|
||||
continue
|
||||
elif sys.argv[i] in ['dump', 'link']:
|
||||
sys.argv[i] = "--%s" % (sys.argv[i])
|
||||
else:
|
||||
break
|
||||
|
||||
import argparse
|
||||
descr = "A module for working with XPCOM Type Libraries."
|
||||
parser = argparse.ArgumentParser(description=descr)
|
||||
|
||||
parser.add_argument('--dump',
|
||||
action='store',
|
||||
dest='dumpfile',
|
||||
metavar='FILE',
|
||||
help='Display in a human-readable format.',
|
||||
)
|
||||
parser.add_argument('--link',
|
||||
nargs='+',
|
||||
action='store',
|
||||
metavar='FILE',
|
||||
dest='linkfile',
|
||||
help='Link all xpt files into a single file',
|
||||
)
|
||||
parser.add_argument('--workaround-bug-754358',
|
||||
action='store_true',
|
||||
dest='bug_754358',
|
||||
help='makefile deps broken, board up broken window',
|
||||
)
|
||||
args = parser.parse_args()
|
||||
argv = vars(args)
|
||||
|
||||
flag = True if argv['bug_754358'] else False
|
||||
Typelib.workaround_bug_754358(set=True, val=flag)
|
||||
|
||||
# xpt.py [--]link @files
|
||||
if argv['linkfile']:
|
||||
if 2 > len(argv['linkfile']):
|
||||
parser.print_help()
|
||||
sys.exit(1)
|
||||
tmp = argv['linkfile']
|
||||
argv['linkfile'] = tmp[0]
|
||||
argv['linkargs'] = tmp[1:]
|
||||
|
||||
# todo: iterate over linkargs: verify exisence and size>0.
|
||||
|
||||
# xpt.py [--]dump file
|
||||
elif argv['dumpfile']:
|
||||
pass
|
||||
|
||||
# Choose
|
||||
else:
|
||||
parser.print_help()
|
||||
sys.exit(1)
|
||||
|
||||
return argv
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
argv = local_argparse()
|
||||
if argv['dumpfile']:
|
||||
xpt_dump(argv['dumpfile'])
|
||||
elif argv['linkfile']:
|
||||
xpt_link(argv['linkargs']).write(argv['linkfile'])
|
||||
|
||||
Loading…
Reference in New Issue
Block a user