Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 21:00:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1685134 - Added Normandy Do Nothing Prefs for testing r=mythmon

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D101068
This commit is contained in:
ttran 2021-01-11 22:31:21 +00:00
parent affae3f451
commit 025dbfb285
4 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
browser/app/profile/firefox.js
View File

@ -2514,3 +2514,10 @@ pref("first-startup.timeout", 30000);
#ifdef XP_WIN
pref("default-browser-agent.enabled", true);
#endif
// Test Prefs that do nothing for testing
#if defined(EARLY_BETA_OR_EARLIER)
pref("app.normandy.test-prefs.bool", false);
pref("app.normandy.test-prefs.integer", 0);
pref("app.normandy.test-prefs.string", "");
#endif

3
toolkit/components/telemetry/app/TelemetryEnvironment.jsm
View File

@ -233,6 +233,9 @@ const DEFAULT_ENVIRONMENT_PREFS = new Map([
["app.support.baseURL", { what: RECORD_PREF_VALUE }],
["accessibility.browsewithcaret", { what: RECORD_PREF_VALUE }],
["accessibility.force_disabled", { what: RECORD_PREF_VALUE }],
["app.normandy.test-prefs.bool", { what: RECORD_PREF_VALUE }],
["app.normandy.test-prefs.integer", { what: RECORD_PREF_VALUE }],
["app.normandy.test-prefs.string", { what: RECORD_PREF_VALUE }],
["app.shield.optoutstudies.enabled", { what: RECORD_PREF_VALUE }],
["app.update.interval", { what: RECORD_PREF_VALUE }],
["app.update.service.enabled", { what: RECORD_PREF_VALUE }],

6
toolkit/components/telemetry/docs/data/environment.rst
View File

@ -400,6 +400,12 @@ The following is a partial list of `collected preferences <https://searchfox.org
- ``toolkit.telemetry.pioneerId``: The state of the Pioneer ID. If set, then user is enrolled in Pioneer. Note that this does *not* collect the value.
- ``app.normandy.test-prefs.bool``: Test pref that will help troubleshoot uneven unenrollment in experiments. Defaults to false.
- ``app.normandy.test-prefs.integer``: Test pref that will help troubleshoot uneven unenrollment in experiments. Defaults to 0.
- ``app.normandy.test-prefs.string``: Test pref that will help troubleshoot uneven unenrollment in experiments. Defaults to "".
attribution
~~~~~~~~~~~

30
toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
View File

@ -2566,6 +2566,36 @@ add_task(
}
);
add_task(async function test_normandyTestPrefsGoneAfter91() {
const testPrefBool = "app.normandy.test-prefs.bool";
const testPrefInteger = "app.normandy.test-prefs.integer";
const testPrefString = "app.normandy.test-prefs.string";
Services.prefs.setBoolPref(testPrefBool, true);
Services.prefs.setIntPref(testPrefInteger, 10);
Services.prefs.setCharPref(testPrefString, "test-string");
const data = TelemetryEnvironment.currentEnvironment;
if (Services.vc.compare(data.build.version, "91") > 0) {
Assert.equal(
data.settings.userPrefs["app.normandy.test-prefs.bool"],
null,
"This probe should expire in FX91. bug 1686105 "
);
Assert.equal(
data.settings.userPrefs["app.normandy.test-prefs.integer"],
null,
"This probe should expire in FX91. bug 1686105 "
);
Assert.equal(
data.settings.userPrefs["app.normandy.test-prefs.string"],
null,
"This probe should expire in FX91. bug 1686105 "
);
}
});
add_task(async function test_environmentShutdown() {
// Define and reset the test preference.
const PREF_TEST = "toolkit.telemetry.test.pref1";