Bug 1577411 - Don't build breakpad host tools on Windows host when building GeckoView. r=firefox-build-system-reviewers,chmanchester

Bug 1558372 allows to build crash reporter for Android even if host isn't
Linux. But when using Windows host, it is still broken.

Host libraries and tools in `toolkit/crashreporter/google-breakpad/src/common`
is only for Linux host and macOS host. So if using Windows host, it isn't
buildable.  So I would like to exclude this if host is windows.

Also, `toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms` is
only for Linux host.

Differential Revision: https://phabricator.services.mozilla.com/D43923

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Makoto Kato 2019-09-04 17:58:35 +00:00
parent 07ce45894d
commit 0330a15cd4
2 changed files with 5 additions and 5 deletions

View File

@ -4,9 +4,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
if CONFIG['OS_ARCH'] in ('Darwin', 'Linux'):
DIRS += ['dwarf']
UNIFIED_SOURCES += [
'convert_UTF.c',
'string_conversion.cc',
@ -30,7 +27,10 @@ elif CONFIG['OS_ARCH'] == 'Darwin':
'-I%s/toolkit/crashreporter/google-breakpad/src/third_party/mac_headers/' % TOPSRCDIR,
]
if CONFIG['OS_ARCH'] != 'WINNT':
if CONFIG['HOST_OS_ARCH'] != 'WINNT':
if CONFIG['OS_ARCH'] in ('Darwin', 'Linux'):
DIRS += ['dwarf']
HOST_SOURCES += [
'arm_ex_reader.cc',
'arm_ex_to_module.cc',

View File

@ -62,7 +62,7 @@ if CONFIG['MOZ_CRASHREPORTER']:
'google-breakpad/src/processor',
'rust',
]
if CONFIG['HOST_OS_ARCH'] != 'Darwin':
if CONFIG['HOST_OS_ARCH'] == 'Linux':
DIRS += ['google-breakpad/src/tools/linux/dump_syms']