Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1485671 - Expose and use TabClient.logInPage instead of sending request manually. r=yulia

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D6272

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Alexandre Poirot 2018-09-20 07:50:54 +00:00
parent 0f4ffbd8c2
commit 036563e90b
2 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
devtools/client/framework/target.js
View File

@ -723,14 +723,7 @@ TabTarget.prototype = {
logErrorInPage: function(text, category) {
if (this.activeTab && this.activeTab.traits.logInPage) {
const errorFlag = 0;
const packet = {
to: this.form.actor,
type: "logInPage",
flags: errorFlag,
text,
category,
};
this.client.request(packet);
this.activeTab.logInPage(text, category, errorFlag);
}
},
@ -745,14 +738,7 @@ TabTarget.prototype = {
logWarningInPage: function(text, category) {
if (this.activeTab && this.activeTab.traits.logInPage) {
const warningFlag = 1;
const packet = {
to: this.form.actor,
type: "logInPage",
flags: warningFlag,
text,
category,
};
this.client.request(packet);
this.activeTab.logInPage(text, category, warningFlag);
}
},
};

7
devtools/shared/client/tab-client.js
View File

@ -140,6 +140,13 @@ TabClient.prototype = {
attachWorker: function(workerTargetActor) {
return this.client.attachWorker(workerTargetActor);
},
logInPage: DebuggerClient.requester({
type: "logInPage",
text: arg(0),
category: arg(1),
flags: arg(2),
}),
};
eventSource(TabClient.prototype);