Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 04:09:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1588086 - Fix the multi-modal getSymbolTable; r=julienw

Browse Source 
The function had the wrong argument parameters, and it wasn't
fetching the latest list of objdirs.

Differential Revision: https://phabricator.services.mozilla.com/D49006

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Greg Tatum 2019-10-15 11:25:18 +00:00
parent d49cb14c71
commit 037581be8e
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
devtools/client/performance-new/browser.js
View File

@ -437,12 +437,12 @@ async function getSymbolTableFromLocalBinary(objdirs, filename, breakpadId) {
* it's dealing with a simpler situation.
*
* @param {object} profile - The raw profie (not gzipped).
* @param {string[]} objdirs - An array of objdir paths on the host machine
* that should be searched for relevant build artifacts.
* @param {() => string[]} getObjdirs - A function that returns an array of objdir paths
* on the host machine that should be searched for relevant build artifacts.
* @param {PerfFront} perfFront
* @return {GetSymbolTableCallback}
*/
function createMultiModalGetSymbolTableFn(profile, objdirs, perfFront) {
function createMultiModalGetSymbolTableFn(profile, getObjdirs, perfFront) {
const libraryGetter = createLibraryMap(profile);
return async function getSymbolTable(debugName, breakpadId) {
@ -473,6 +473,7 @@ function createMultiModalGetSymbolTableFn(profile, objdirs, perfFront) {
// We check the host machine first, because if this is a developer
// build, then the objdir files will contain more symbol information
// than the files that get pushed to the device.
const objdirs = getObjdirs();
return await getSymbolTableFromLocalBinary(objdirs, name, breakpadId);
} catch (e) {
// No matching file was found on the host machine.

4
devtools/client/performance-new/initializer.js
View File

@ -81,8 +81,8 @@ async function gInit(perfFront, preferenceFront) {
profile =>
createMultiModalGetSymbolTableFn(
profile,
selectors.getPerfFront(store.getState()),
selectors.getObjdirs(store.getState())
() => selectors.getObjdirs(store.getState()),
selectors.getPerfFront(store.getState())
),
})
);