Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 05:15:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Get rid of bogus assertions from OnAddURI/OnDeleteURI and instead notify observers of a visit-time change if the page is bookmarked.

Browse Source
This commit is contained in:
bryner%brianryner.com 2005-11-29 21:59:13 +00:00
parent 89196348d2
commit 0418c05b64
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
browser/components/places/src/nsNavBookmarks.cpp
View File

@ -1020,24 +1020,28 @@ nsNavBookmarks::GetWantAllDetails(PRBool *aWant)
NS_IMETHODIMP
nsNavBookmarks::OnAddURI(nsIURI *aURI, PRTime aTime)
{
// A new URI won't yet be bookmarked, so don't notify.
#ifdef DEBUG
// If the page is bookmarked, we need to notify observers
PRBool bookmarked;
IsBookmarked(aURI, &bookmarked);
NS_ASSERTION(!bookmarked, "New URI shouldn't be bookmarked!");
#endif
if (bookmarked) {
for (PRInt32 i = 0; i < mObservers.Count(); ++i) {
mObservers[i]->OnItemChanged(aURI, NS_LITERAL_CSTRING("time"));
}
}
return NS_OK;
}
NS_IMETHODIMP
nsNavBookmarks::OnDeleteURI(nsIURI *aURI)
{
// A deleted URI shouldn't be bookmarked.
#ifdef DEBUG
// If the page is bookmarked, we need to notify observers
PRBool bookmarked;
IsBookmarked(aURI, &bookmarked);
NS_ASSERTION(!bookmarked, "Deleted URI shouldn't be bookmarked!");
#endif
if (bookmarked) {
for (PRInt32 i = 0; i < mObservers.Count(); ++i) {
mObservers[i]->OnItemChanged(aURI, NS_LITERAL_CSTRING("time"));
}
}
return NS_OK;
}