From 04b28aaeada95ef0875a4520bed26b299f0544e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Wed, 7 Dec 2022 18:44:58 +0000 Subject: [PATCH] Bug 1755564 - Tweak spell checker underline color in dark mode. r=spohl I think this is a slightly better color and saves me from actually making a decision over the options in comment 9 and so on. I'll ask Firefox UX to take a look at comment 9 so that they can evaluate and make a decision (and maybe tweaking our link colors), if we want to change it. Depends on D163402 Differential Revision: https://phabricator.services.mozilla.com/D163403 --- widget/nsXPLookAndFeel.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/widget/nsXPLookAndFeel.cpp b/widget/nsXPLookAndFeel.cpp index 9be1e9a0cce9..d4104e99ff06 100644 --- a/widget/nsXPLookAndFeel.cpp +++ b/widget/nsXPLookAndFeel.cpp @@ -837,7 +837,12 @@ Maybe nsXPLookAndFeel::GenericDarkColor(ColorID aID) { // value of browser.visited_color.dark. color = NS_RGB(0xff, 0xad, 0xff); break; - + case ColorID::SpellCheckerUnderline: + // This is the default for active links in dark mode as well + // (browser.active_color.dark). See bug 1755564 for some analysis and + // other options too. + color = NS_RGB(0xff, 0x66, 0x66); + break; default: return Nothing(); }