Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-28 21:28:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1453921: Use MTruncateToInt32 when inlining String.fromCharCode. r=jandem

Browse Source
This commit is contained in:
André Bargull 2018-04-13 03:40:51 -07:00
parent 288735f7e2
commit 0678b75f37
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
js/src/jit/MCallOptimize.cpp
View File

@ -1933,12 +1933,21 @@ IonBuilder::inlineStrFromCharCode(CallInfo& callInfo)
if (getInlineReturnType() != MIRType::String)
return InliningStatus_NotInlined;
if (callInfo.getArg(0)->type() != MIRType::Int32)
return InliningStatus_NotInlined;
MDefinition* codeUnit = callInfo.getArg(0);
if (codeUnit->type() != MIRType::Int32) {
// MTruncateToInt32 will always bail for objects and symbols, so don't
// try to inline String.fromCharCode() for these two value types.
if (codeUnit->mightBeType(MIRType::Object) || codeUnit->mightBeType(MIRType::Symbol))
return InliningStatus_NotInlined;
codeUnit = MTruncateToInt32::New(alloc(), codeUnit);
current->add(codeUnit->toInstruction());
}
callInfo.setImplicitlyUsedUnchecked();
MFromCharCode* string = MFromCharCode::New(alloc(), callInfo.getArg(0));
MFromCharCode* string = MFromCharCode::New(alloc(), codeUnit);
current->add(string);
current->push(string);
return InliningStatus_Inlined;