mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-26 19:55:39 +00:00
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry r=liuche
We want to be able to detect when we've opened a reader view item. Note: this is independent of whether or not we're in the Reading List smartfolder: it's possible to open reader view bookmarks from any real bookmark folder, or the smartfolder. MozReview-Commit-ID: KhqclodWSji --HG-- extra : amend_source : 96460a430de900920dc2858dc171544657771abb
This commit is contained in:
parent
e3a101f136
commit
069a4f4f33
@ -24,6 +24,8 @@ import android.view.View;
|
||||
import android.widget.AdapterView;
|
||||
import android.widget.HeaderViewListAdapter;
|
||||
import android.widget.ListAdapter;
|
||||
|
||||
import org.mozilla.gecko.reader.SavedReaderViewHelper;
|
||||
import org.mozilla.gecko.util.NetworkUtils;
|
||||
|
||||
/**
|
||||
@ -169,7 +171,16 @@ public class BookmarksListView extends HomeListView
|
||||
// Otherwise, just open the URL
|
||||
final String url = cursor.getString(cursor.getColumnIndexOrThrow(Bookmarks.URL));
|
||||
|
||||
Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.LIST_ITEM, "bookmarks");
|
||||
final SavedReaderViewHelper rvh = SavedReaderViewHelper.getSavedReaderViewHelper(getContext());
|
||||
|
||||
final String extra;
|
||||
if (rvh.isURLCached(url)) {
|
||||
extra = "bookmarks-reader";
|
||||
} else {
|
||||
extra = "bookmarks";
|
||||
}
|
||||
|
||||
Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.LIST_ITEM, extra);
|
||||
Telemetry.addToHistogram("FENNEC_LOAD_SAVED_PAGE", NetworkUtils.isConnected(getContext()) ? 2 : 3);
|
||||
|
||||
// This item is a TwoLinePageRow, so we allow switch-to-tab.
|
||||
|
Loading…
Reference in New Issue
Block a user