Consolidate SetEnabled and SetDisabled; make sure both of them clear the rule cascade on the rule processors. Bug 230651, r+sr=bzbarsky.

This commit is contained in:
bryner%brianryner.com 2004-01-15 03:26:56 +00:00
parent 107a86d7ae
commit 072b7160a8
2 changed files with 6 additions and 24 deletions

View File

@ -1873,18 +1873,7 @@ CSSStyleSheetImpl::GetApplicable(PRBool& aApplicable) const
NS_IMETHODIMP
CSSStyleSheetImpl::SetEnabled(PRBool aEnabled)
{
PRBool oldDisabled = mDisabled;
mDisabled = !aEnabled;
if (mDocument && mInner && mInner->mComplete && oldDisabled != mDisabled) {
ClearRuleCascades();
mDocument->BeginUpdate(UPDATE_STYLE);
mDocument->SetStyleSheetApplicableState(this, !mDisabled);
mDocument->EndUpdate(UPDATE_STYLE);
}
return NS_OK;
return CSSStyleSheetImpl::SetDisabled(!aEnabled);
}
NS_IMETHODIMP
@ -2446,6 +2435,8 @@ CSSStyleSheetImpl::SetDisabled(PRBool aDisabled)
mDisabled = aDisabled;
if (mDocument && mInner && mInner->mComplete && oldDisabled != mDisabled) {
ClearRuleCascades();
mDocument->BeginUpdate(UPDATE_STYLE);
mDocument->SetStyleSheetApplicableState(this, !mDisabled);
mDocument->EndUpdate(UPDATE_STYLE);

View File

@ -1873,18 +1873,7 @@ CSSStyleSheetImpl::GetApplicable(PRBool& aApplicable) const
NS_IMETHODIMP
CSSStyleSheetImpl::SetEnabled(PRBool aEnabled)
{
PRBool oldDisabled = mDisabled;
mDisabled = !aEnabled;
if (mDocument && mInner && mInner->mComplete && oldDisabled != mDisabled) {
ClearRuleCascades();
mDocument->BeginUpdate(UPDATE_STYLE);
mDocument->SetStyleSheetApplicableState(this, !mDisabled);
mDocument->EndUpdate(UPDATE_STYLE);
}
return NS_OK;
return CSSStyleSheetImpl::SetDisabled(!aEnabled);
}
NS_IMETHODIMP
@ -2446,6 +2435,8 @@ CSSStyleSheetImpl::SetDisabled(PRBool aDisabled)
mDisabled = aDisabled;
if (mDocument && mInner && mInner->mComplete && oldDisabled != mDisabled) {
ClearRuleCascades();
mDocument->BeginUpdate(UPDATE_STYLE);
mDocument->SetStyleSheetApplicableState(this, !mDisabled);
mDocument->EndUpdate(UPDATE_STYLE);