mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-01-08 20:43:50 +00:00
Bug 250547: Make FlagTypes use INNER JOIN instead of comma operator.
Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=jouni, a=justdave
This commit is contained in:
parent
b4a9c5210a
commit
078b6d1054
@ -326,8 +326,8 @@ sub sqlify_criteria {
|
||||
|
||||
# Add inclusions to the query, which simply involves joining the table
|
||||
# by flag type ID and target product/component.
|
||||
push(@$tables, ", flaginclusions");
|
||||
push(@criteria, "flagtypes.id = flaginclusions.type_id");
|
||||
push(@$tables, "INNER JOIN flaginclusions ON " .
|
||||
"flagtypes.id = flaginclusions.type_id");
|
||||
push(@criteria, "(flaginclusions.product_id = $product_id " .
|
||||
" OR flaginclusions.product_id IS NULL)");
|
||||
push(@criteria, "(flaginclusions.component_id = $component_id " .
|
||||
|
Loading…
Reference in New Issue
Block a user