Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 18:08:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1857155 - Make sure FileSystemWritableFileStream can't go away during Seek, Truncate and Close/Abort; r=dom-storage-reviewers,jari

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D190168
This commit is contained in:
Jan Varga 2023-10-09 21:42:25 +00:00
parent 3146505a67
commit 07c537ddc2
1 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
dom/fs/api/FileSystemWritableFileStream.cpp
View File

@ -444,8 +444,8 @@ RefPtr<BoolPromise> FileSystemWritableFileStream::BeginFinishing(
if (mCloseHandler->SetClosing()) {
Finish()
->Then(mTaskQueue, __func__,
[streamOwner = mStreamOwner]() mutable {
streamOwner->Close();
[selfHolder = fs::TargetPtrHolder(this)]() mutable {
selfHolder->mStreamOwner->Close();
return BoolPromise::CreateAndResolve(true, __func__);
})
@ -901,25 +901,27 @@ RefPtr<BoolPromise> FileSystemWritableFileStream::Seek(uint64_t aPosition) {
LOG_VERBOSE(("%p: Seeking to %" PRIu64, mStreamOwner.get(), aPosition));
return InvokeAsync(mTaskQueue, __func__,
[aPosition, streamOwner = mStreamOwner]() mutable {
QM_TRY(MOZ_TO_RESULT(streamOwner->Seek(aPosition)),
CreateAndRejectBoolPromise);
return InvokeAsync(
mTaskQueue, __func__,
[selfHolder = fs::TargetPtrHolder(this), aPosition]() mutable {
QM_TRY(MOZ_TO_RESULT(selfHolder->mStreamOwner->Seek(aPosition)),
CreateAndRejectBoolPromise);
return BoolPromise::CreateAndResolve(true, __func__);
});
return BoolPromise::CreateAndResolve(true, __func__);
});
}
RefPtr<BoolPromise> FileSystemWritableFileStream::Truncate(uint64_t aSize) {
MOZ_ASSERT(IsOpen());
return InvokeAsync(mTaskQueue, __func__,
[aSize, streamOwner = mStreamOwner]() mutable {
QM_TRY(MOZ_TO_RESULT(streamOwner->Truncate(aSize)),
CreateAndRejectBoolPromise);
return InvokeAsync(
mTaskQueue, __func__,
[selfHolder = fs::TargetPtrHolder(this), aSize]() mutable {
QM_TRY(MOZ_TO_RESULT(selfHolder->mStreamOwner->Truncate(aSize)),
CreateAndRejectBoolPromise);
return BoolPromise::CreateAndResolve(true, __func__);
});
return BoolPromise::CreateAndResolve(true, __func__);
});
}
void FileSystemWritableFileStream::NoteFinishedCommand() {