Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 18:08:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1700124 - de-duplicate add (+) icons r=thecount,harry,desktop-theme-reviewers

Browse Source 
* Rename toolkit's add.svg to plus.svg, use it for the zoom-in buttons and about:newtab's add icon

Differential Revision: https://phabricator.services.mozilla.com/D118627
This commit is contained in:
Sam Foster 2021-07-08 18:52:40 +00:00
parent 90efefc3d2
commit 08389c68f4
15 changed files with 10 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/components/newtab/content-src/styles/_icons.scss
View File

@ -189,7 +189,7 @@
}
&.icon-add {
background-image: url('chrome://activity-stream/content/data/content/assets/glyph-add-16.svg');
background-image: url('chrome://global/skin/icons/plus.svg');
}
&.icon-minimize {

2
browser/components/newtab/css/activity-stream-linux.css
View File

@ -346,7 +346,7 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://global/skin/icons/arrow-up.svg");
}
.icon.icon-add {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-add-16.svg");
background-image: url("chrome://global/skin/icons/plus.svg");
}
.icon.icon-minimize {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-minimize-16.svg");

2
browser/components/newtab/css/activity-stream-mac.css
View File

@ -350,7 +350,7 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://global/skin/icons/arrow-up.svg");
}
.icon.icon-add {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-add-16.svg");
background-image: url("chrome://global/skin/icons/plus.svg");
}
.icon.icon-minimize {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-minimize-16.svg");

2
browser/components/newtab/css/activity-stream-windows.css
View File

@ -346,7 +346,7 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://global/skin/icons/arrow-up.svg");
}
.icon.icon-add {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-add-16.svg");
background-image: url("chrome://global/skin/icons/plus.svg");
}
.icon.icon-minimize {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-minimize-16.svg");

6
browser/components/newtab/data/content/assets/glyph-add-16.svg
View File

@ -1,6 +0,0 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
<path d="M8 9.75 8 14a.625.625 0 0 0 1.25 0l0-4.25.5-.5 4.25 0A.625.625 0 0 0 14 8L9.75 8l-.5-.5 0-4.25a.625.625 0 0 0-1.25 0L8 7.5l-.5.5-4.25 0a.625.625 0 0 0 0 1.25l4.137 0 .613.5z"/>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 547 B

2
browser/components/touchbar/MacTouchBar.js
View File

@ -120,7 +120,7 @@ var gBuiltInInputs = {
},
NewTab: {
title: "new-tab",
image: "chrome://global/skin/icons/add.svg",
image: "chrome://global/skin/icons/plus.svg",
type: kInputTypes.BUTTON,
callback: () => execCommand("cmd_newNavigatorTabNoEvent"),
},

4
browser/installer/allowed-dupes.mn
View File

@ -118,10 +118,6 @@ browser/chrome/browser/skin/classic/browser/customize.svg
browser/features/webcompat-reporter@mozilla.org/icons/lightbulb.svg
chrome/toolkit/skin/classic/global/icons/lightbulb.svg
# Bug 1700124 - De-duplicate browser/themes/shared icons
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-add-16.svg
browser/chrome/browser/skin/classic/browser/zoom-in.svg
# Bug 1710546 - Bundle Firefox extension as a builtin addon Nighly only
# We plan to remove this duplicity after Firefox Translations become pref'd on
browser/chrome/browser/builtin-addons/translations/wasm/cld-worker.js.mem

2
browser/themes/osx/browser.css
View File

@ -259,7 +259,7 @@ moz-input-box > menupopup .context-menu-add-engine > .menu-iconic-left {
min-height: 24px;
height: 24px;
color: inherit;
list-style-image: url("chrome://global/skin/icons/add.svg");
list-style-image: url("chrome://global/skin/icons/plus.svg");
}
#editBMPanel_newFolderButton:hover {

6
browser/themes/shared/icons/zoom-in.svg
View File

@ -1,6 +0,0 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
<path d="M8 9.75 8 14a.625.625 0 0 0 1.25 0l0-4.25.5-.5 4.25 0A.625.625 0 0 0 14 8L9.75 8l-.5-.5 0-4.25a.625.625 0 0 0-1.25 0L8 7.5l-.5.5-4.25 0a.625.625 0 0 0 0 1.25l4.137 0 .613.5z"/>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 547 B

1
browser/themes/shared/jar.inc.mn
View File

@ -185,7 +185,6 @@
skin/classic/browser/tab.svg (../shared/icons/tab.svg)
skin/classic/browser/whatsnew.svg (../shared/icons/whatsnew.svg)
skin/classic/browser/window.svg (../shared/icons/window.svg)
skin/classic/browser/zoom-in.svg (../shared/icons/zoom-in.svg)
skin/classic/browser/zoom-out.svg (../shared/icons/zoom-out.svg)
skin/classic/browser/ion.svg (../shared/icons/ion.svg)

2
browser/themes/shared/tabs.inc.css
View File

@ -690,7 +690,7 @@
#tabs-newtab-button,
#TabsToolbar #new-tab-button {
list-style-image: url(chrome://global/skin/icons/add.svg);
list-style-image: url(chrome://global/skin/icons/plus.svg);
}
/* All tabs button and menupopup */

2
browser/themes/shared/toolbarbutton-icons.inc.css
View File

@ -335,7 +335,7 @@ toolbar[brighttext]:-moz-lwtheme {
}
#zoom-in-button {
list-style-image: url("chrome://browser/skin/zoom-in.svg");
list-style-image: url("chrome://global/skin/icons/plus.svg");
}
#zoom-in-button > .toolbarbutton-icon {

2
toolkit/components/aboutconfig/content/aboutconfig.css
View File

@ -228,7 +228,7 @@ td.cell-value > form > input[type="number"] {
}
.button-add {
background-image: url("chrome://global/skin/icons/add.svg");
background-image: url("chrome://global/skin/icons/plus.svg");
}
.button-save {

0
toolkit/themes/shared/icons/add.svg → toolkit/themes/shared/icons/plus.svg
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 527 B

After

Width:  |  Height:  |  Size: 527 B

2
toolkit/themes/shared/jar.inc.mn
View File

@ -30,7 +30,6 @@ toolkit.jar:
skin/classic/global/numberinput.css (../../shared/numberinput.css)
skin/classic/global/in-content/info-pages.css (../../shared/in-content/info-pages.css)
skin/classic/global/in-content/toggle-button.css (../../shared/in-content/toggle-button.css)
skin/classic/global/icons/add.svg (../../shared/icons/add.svg)
skin/classic/global/icons/arrow-left.svg (../../shared/icons/arrow-left.svg)
skin/classic/global/icons/arrow-right.svg (../../shared/icons/arrow-right.svg)
skin/classic/global/icons/autoscroll.svg (../../shared/icons/autoscroll.svg)
@ -63,6 +62,7 @@ toolkit.jar:
skin/classic/global/icons/performance.svg (../../shared/icons/performance.svg)
skin/classic/global/icons/plugin.svg (../../shared/icons/plugin.svg)
skin/classic/global/icons/plugin-blocked.svg (../../shared/icons/plugin-blocked.svg)
skin/classic/global/icons/plus.svg (../../shared/icons/plus.svg)
skin/classic/global/icons/pocket.svg (../../shared/icons/pocket.svg)
skin/classic/global/icons/print.svg (../../shared/icons/print.svg)
skin/classic/global/icons/undo.svg (../../shared/icons/undo.svg)