Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 14:52:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1835300: Allow CacheAPI in PBM if pref is toggled. r=dom-storage-reviewers,asuth

Browse Source 
Depends on D180295

Differential Revision: https://phabricator.services.mozilla.com/D180296
This commit is contained in:
hsingh 2023-10-27 14:10:07 +00:00
parent 8735c02c0b
commit 0890b51845
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dom/cache/CacheStorage.cpp vendored
View File

@ -175,7 +175,8 @@ already_AddRefed<CacheStorage> CacheStorage::CreateOnWorker(
MOZ_DIAGNOSTIC_ASSERT(aWorkerPrivate);
aWorkerPrivate->AssertIsOnWorkerThread();
if (aWorkerPrivate->GetOriginAttributes().mPrivateBrowsingId > 0) {
if (aWorkerPrivate->GetOriginAttributes().mPrivateBrowsingId > 0 &&
!StaticPrefs::dom_cache_privateBrowsing_enabled()) {
NS_WARNING("CacheStorage not supported during private browsing.");
RefPtr<CacheStorage> ref = new CacheStorage(NS_ERROR_DOM_SECURITY_ERR);
return ref.forget();
@ -574,16 +575,17 @@ bool CacheStorage::HasStorageAccess(UseCounter aLabel,
}
}
// Deny storage access for private browsing.
// Deny storage access for private browsing unless pref is toggled on.
if (nsIPrincipal* principal = mGlobal->PrincipalOrNull()) {
if (!principal->IsSystemPrincipal() &&
principal->GetPrivateBrowsingId() !=
nsIScriptSecurityManager::DEFAULT_PRIVATE_BROWSING_ID) {
nsIScriptSecurityManager::DEFAULT_PRIVATE_BROWSING_ID &&
!StaticPrefs::dom_cache_privateBrowsing_enabled()) {
return false;
}
}
return access > StorageAccess::ePrivateBrowsing ||
return access > StorageAccess::eDeny ||
(StaticPrefs::
privacy_partition_always_partition_third_party_non_cookie_storage() &&
ShouldPartitionStorage(access));