Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1534840 part 1 - Add an assertion to check that we can generate contiguous jump tables. r=sstangl

Browse Source 
Depends on D26520

Differential Revision: https://phabricator.services.mozilla.com/D26521

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Nicolas B. Pierron 2019-04-16 13:56:48 +00:00
parent 50c7913e7f
commit 092c959227
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/src/jit/shared/IonAssemblerBufferWithConstantPools.h
View File

@ -956,12 +956,15 @@ struct AssemblerBufferWithConstantPools
size_t(branchDeadlines_.earliestDeadline().getOffset());
}
bool isPoolEmpty() const {
return pool_.numEntries() == 0 && !hasExpirableShortRangeBranches();
}
void finishPool() {
JitSpew(JitSpew_Pools,
"[%d] Attempting to finish pool %zu with %u entries.", id,
poolInfo_.length(), pool_.numEntries());
if (pool_.numEntries() == 0 && !hasExpirableShortRangeBranches()) {
if (isPoolEmpty()) {
// If there is no data in the pool being dumped, don't dump anything.
JitSpew(JitSpew_Pools, "[%d] Aborting because the pool is empty", id);
return;
@ -1101,6 +1104,9 @@ struct AssemblerBufferWithConstantPools
MOZ_ASSERT(inhibitNops_);
inhibitNops_ = false;
}
void assertNoPoolAndNoNops() {
MOZ_ASSERT(inhibitNops_ && (isPoolEmpty() || canNotPlacePool_));
}
void align(unsigned alignment) { align(alignment, alignFillInst_); }
@ -1127,11 +1133,12 @@ struct AssemblerBufferWithConstantPools
finishPool();
}
bool prevInhibitNops = inhibitNops_;
inhibitNops_ = true;
while ((sizeExcludingCurrentPool() & (alignment - 1)) && !this->oom()) {
putInt(pattern);
}
inhibitNops_ = false;
inhibitNops_ = prevInhibitNops;
}
public: