Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 00:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixes one of the crashes reported in bug 190326 "crash in nsJARChannel.cpp

Browse Source 
when launching calendar" r=dougt sr=bzbarsky a=asa
This commit is contained in:
darin%netscape.com 2003-01-28 19:13:52 +00:00
parent 3a46194bdd
commit 0992b66980
2 changed files with 50 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
modules/libjar/nsJARChannel.cpp
View File

@ -59,6 +59,7 @@ public:
: mJarCache(jarCache)
, mJarFile(jarFile)
, mJarEntry(jarEntry)
, mContentLength(-1)
{
NS_ASSERTION(mJarFile, "no jar file");
}
@ -66,7 +67,12 @@ public:
void GetJarReader(nsIZipReader **result)
{
NS_ADDREF(*result = mJarReader);
NS_IF_ADDREF(*result = mJarReader);
}
PRInt32 GetContentLength()
{
return mContentLength;
}
private:
@ -77,6 +83,7 @@ private:
nsCOMPtr<nsIFile> mJarFile;
nsCOMPtr<nsIInputStream> mJarStream;
nsCString mJarEntry;
PRInt32 mContentLength;
};
NS_IMPL_THREADSAFE_ISUPPORTS1(nsJARInputThunk, nsIInputStream)
@ -87,11 +94,22 @@ nsJARInputThunk::EnsureJarStream()
if (mJarStream)
return NS_OK;
nsresult rv = mJarCache->GetZip(mJarFile, getter_AddRefs(mJarReader));
nsresult rv;
rv = mJarCache->GetZip(mJarFile, getter_AddRefs(mJarReader));
if (NS_FAILED(rv)) return rv;
return mJarReader->GetInputStream(mJarEntry.get(),
getter_AddRefs(mJarStream));
rv = mJarReader->GetInputStream(mJarEntry.get(),
getter_AddRefs(mJarStream));
if (NS_FAILED(rv)) return rv;
// ask the zip entry for the content length
nsCOMPtr<nsIZipEntry> entry;
mJarReader->GetEntry(mJarEntry.get(), getter_AddRefs(entry));
if (entry)
entry->GetRealSize((PRUint32 *) &mContentLength);
return NS_OK;
}
NS_IMETHODIMP
@ -510,17 +528,9 @@ nsJARChannel::SetContentCharset(const nsACString &aContentCharset)
NS_IMETHODIMP
nsJARChannel::GetContentLength(PRInt32 *result)
{
if (mContentLength < 0 && mJarInput) {
// ask the zip entry for the content length
nsCOMPtr<nsIZipReader> jarReader;
mJarInput->GetJarReader(getter_AddRefs(jarReader));
if (jarReader) {
nsCOMPtr<nsIZipEntry> entry;
jarReader->GetEntry(mJarEntry.get(), getter_AddRefs(entry));
if (entry)
entry->GetRealSize((PRUint32 *) &mContentLength);
}
}
// if content length is unknown, query mJarInput...
if (mContentLength < 0 && mJarInput)
mContentLength = mJarInput->GetContentLength();
*result = mContentLength;
return NS_OK;

40
netwerk/protocol/jar/src/nsJARChannel.cpp
View File

@ -59,6 +59,7 @@ public:
: mJarCache(jarCache)
, mJarFile(jarFile)
, mJarEntry(jarEntry)
, mContentLength(-1)
{
NS_ASSERTION(mJarFile, "no jar file");
}
@ -66,7 +67,12 @@ public:
void GetJarReader(nsIZipReader **result)
{
NS_ADDREF(*result = mJarReader);
NS_IF_ADDREF(*result = mJarReader);
}
PRInt32 GetContentLength()
{
return mContentLength;
}
private:
@ -77,6 +83,7 @@ private:
nsCOMPtr<nsIFile> mJarFile;
nsCOMPtr<nsIInputStream> mJarStream;
nsCString mJarEntry;
PRInt32 mContentLength;
};
NS_IMPL_THREADSAFE_ISUPPORTS1(nsJARInputThunk, nsIInputStream)
@ -87,11 +94,22 @@ nsJARInputThunk::EnsureJarStream()
if (mJarStream)
return NS_OK;
nsresult rv = mJarCache->GetZip(mJarFile, getter_AddRefs(mJarReader));
nsresult rv;
rv = mJarCache->GetZip(mJarFile, getter_AddRefs(mJarReader));
if (NS_FAILED(rv)) return rv;
return mJarReader->GetInputStream(mJarEntry.get(),
getter_AddRefs(mJarStream));
rv = mJarReader->GetInputStream(mJarEntry.get(),
getter_AddRefs(mJarStream));
if (NS_FAILED(rv)) return rv;
// ask the zip entry for the content length
nsCOMPtr<nsIZipEntry> entry;
mJarReader->GetEntry(mJarEntry.get(), getter_AddRefs(entry));
if (entry)
entry->GetRealSize((PRUint32 *) &mContentLength);
return NS_OK;
}
NS_IMETHODIMP
@ -510,17 +528,9 @@ nsJARChannel::SetContentCharset(const nsACString &aContentCharset)
NS_IMETHODIMP
nsJARChannel::GetContentLength(PRInt32 *result)
{
if (mContentLength < 0 && mJarInput) {
// ask the zip entry for the content length
nsCOMPtr<nsIZipReader> jarReader;
mJarInput->GetJarReader(getter_AddRefs(jarReader));
if (jarReader) {
nsCOMPtr<nsIZipEntry> entry;
jarReader->GetEntry(mJarEntry.get(), getter_AddRefs(entry));
if (entry)
entry->GetRealSize((PRUint32 *) &mContentLength);
}
}
// if content length is unknown, query mJarInput...
if (mContentLength < 0 && mJarInput)
mContentLength = mJarInput->GetContentLength();
*result = mContentLength;
return NS_OK;