From 0a32331ddf2fbc5a44c28b50fad5610d790d3c5d Mon Sep 17 00:00:00 2001 From: Nathan Froyd Date: Wed, 15 Jul 2020 12:58:52 +0000 Subject: [PATCH] Bug 1652870 - permit DUMP_SYMS to be used when doing Android builds; r=mhentges It's not immediately obvious to me why we limit this check based on target; I guess once upon a time there was no ELF or Mach-O support, so we wanted to ensure people didn't shoot themselves in the foot. If that's the case, testing indicates that Mach-O support isn't quite ready for prime-time and we haven't got all the bits straightened out for our normal Linux builds. So we're just going to enable it for Android here. Differential Revision: https://phabricator.services.mozilla.com/D83560 --- toolkit/moz.configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/moz.configure b/toolkit/moz.configure index fcc24bdba0ca..bc285ab12910 100644 --- a/toolkit/moz.configure +++ b/toolkit/moz.configure @@ -1967,7 +1967,7 @@ set_define('MOZ_RUST_FXA_CLIENT', True, when=rust_fxa_client) # ============================================================== check_prog('DUMP_SYMS', ['dump_syms'], allow_missing=True, paths=toolchain_search_path, - when=compile_environment & target_is_windows) + when=compile_environment & (target_is_windows | target_is_android)) check_prog('PDBSTR', ['pdbstr.exe'], allow_missing=True, paths=toolchain_search_path,