Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 11:55:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 903212 - Add a GC when popping a script entry point. r=mrbkap

Browse Source 
I think that this is more or less isomorphic with the MaybeGC we do in
ScriptEvaluated in the cases that matter. And doing it in a spec-defined
place is helpful in getting rid of spec-nonsensical machinery.
This commit is contained in:
Bobby Holley 2013-08-14 14:00:02 -07:00
parent 4c9559f8e1
commit 0a570c79b5
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/xpconnect/src/nsCxPusher.cpp
View File

@ -146,6 +146,15 @@ AutoCxPusher::AutoCxPusher(JSContext* cx, bool allowNull) : mScriptIsRunning(fal
NS_EXPORT
AutoCxPusher::~AutoCxPusher()
{
// GC when we pop a script entry point. This is a useful heuristic that helps
// us out on certain (flawed) benchmarks like sunspider, because it lets us
// avoid GCing during the timing loop.
//
// NB: We need to take care to only do this if we're in a compartment,
// otherwise JS_MaybeGC will segfault.
if (mScx && !mAutoCompartment.empty())
JS_MaybeGC(nsXPConnect::XPConnect()->GetCurrentJSContext());
// Leave the compartment and request before popping.
mAutoCompartment.destroyIfConstructed();
mAutoRequest.destroyIfConstructed();