From 0ac0cb07ec4ae2c0c80890317f213926ea5b69b6 Mon Sep 17 00:00:00 2001 From: Michael Ratcliffe Date: Thu, 30 Oct 2014 13:35:25 +0000 Subject: [PATCH] Bug 1078455 - "UITour: Add ability to highlight Dev. Tools and WebIDE toolbar buttons" [r=MattN+bmo] --- browser/modules/UITour.jsm | 2 ++ .../test/browser_UITour_availableTargets.js | 17 +++++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/browser/modules/UITour.jsm b/browser/modules/UITour.jsm index 7c457237f1f0..742e2de5dad9 100644 --- a/browser/modules/UITour.jsm +++ b/browser/modules/UITour.jsm @@ -101,6 +101,8 @@ this.UITour = { ["help", {query: "#PanelUI-help"}], ["home", {query: "#home-button"}], ["loop", {query: "#loop-call-button"}], + ["devtools", {query: "#developer-button"}], + ["webide", {query: "#webide-button"}], ["forget", { query: "#panic-button", widgetName: "panic-button", diff --git a/browser/modules/test/browser_UITour_availableTargets.js b/browser/modules/test/browser_UITour_availableTargets.js index d322da57b4e0..256f84f69cf8 100644 --- a/browser/modules/test/browser_UITour_availableTargets.js +++ b/browser/modules/test/browser_UITour_availableTargets.js @@ -9,6 +9,8 @@ let gContentWindow; Components.utils.import("resource:///modules/UITour.jsm"); +let hasWebIDE = Services.prefs.getBoolPref("devtools.webide.widget.enabled"); + function test() { requestLongerTimeout(2); UITourTest(); @@ -34,13 +36,17 @@ let tests = [ "help", "home", "loop", + "devtools", "pinnedTab", "privateWindow", "quit", "search", "searchProvider", "urlbar", - ].concat(searchEngineTargets())); + ...searchEngineTargets(), + ...(hasWebIDE ? ["webide"] : []) + ]); + ok(UITour.availableTargetsCache.has(window), "Targets should now be cached"); done(); @@ -60,6 +66,7 @@ let tests = [ "customize", "help", "loop", + "devtools", "home", "pinnedTab", "privateWindow", @@ -67,7 +74,10 @@ let tests = [ "search", "searchProvider", "urlbar", - ].concat(searchEngineTargets())); + ...searchEngineTargets(), + ...(hasWebIDE ? ["webide"] : []) + ]); + ok(UITour.availableTargetsCache.has(window), "Targets should now be cached again"); CustomizableUI.reset(); @@ -93,11 +103,14 @@ let tests = [ "help", "home", "loop", + "devtools", "pinnedTab", "privateWindow", "quit", "urlbar", + ...(hasWebIDE ? ["webide"] : []) ]); + CustomizableUI.reset(); done(); });