Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 03:49:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1864815 - Fix up cssRules when calling replace() repeatedly. r=nordzilla

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D195234
This commit is contained in:
Emilio Cobos Álvarez 2023-12-01 18:18:13 +00:00
parent af9d2a58f2
commit 0bd15bdcf7
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
layout/style/StyleSheet.cpp
View File

@ -1218,6 +1218,7 @@ void StyleSheet::FinishAsyncParse(
MOZ_ASSERT(!mParsePromise.IsEmpty());
Inner().mContents = aSheetContents;
Inner().mUseCounters = std::move(aUseCounters);
FixUpRuleListAfterContentsChangeIfNeeded();
mParsePromise.Resolve(true, __func__);
}

41
testing/web-platform/tests/css/cssom/CSSStyleSheet-constructable-replace-cssRules.html Normal file
View File

@ -0,0 +1,41 @@
<!doctype html>
<meta charset="utf-8">
<title>CSSStyleSheet.replace reflects the right cssRules.</title>
<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
<link rel="author" title="Mozilla" href="https://mozilla.org">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1864815">
<link rel="help" href="https://drafts.csswg.org/cssom/#dom-cssstylesheet-replace">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<p></p>
<script>
async function runTest(sync) {
let sheet = new CSSStyleSheet();
let rules = sheet.cssRules;
function replace(text) {
return sync ? sheet.replaceSync(text) : sheet.replace(text);
}
function assert_color(color) {
assert_equals(sheet.cssRules, rules, "StyleSheet.cssRules is [SameObject]");
assert_equals(rules.length, 1, "Should have one rule");
assert_equals(rules[0].style.color, color, "Should be the right css rule");
}
async function replace_and_test(color) {
await replace(`p { color: ${color} }`);
assert_equals(sheet.cssRules, rules, "StyleSheet.cssRules is [SameObject]");
assert_equals(rules.length, 1, "Should have one rule");
assert_equals(rules[0].style.color, color, "Should be the right css rule");
}
await replace_and_test("red");
await replace_and_test("green");
document.adoptedStyleSheets.push(sheet);
assert_equals(getComputedStyle(document.querySelector("p")).color, "rgb(0, 128, 0)", "Sheet should apply");
document.adoptedStyleSheets.pop(sheet);
assert_not_equals(getComputedStyle(document.querySelector("p")).color, "rgb(0, 128, 0)", "Sheet should stop applying");
}
for (let sync of [true, false]) {
promise_test(() => runTest(sync), `cssRules tests (sync: ${sync})`);
}
</script>