Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-12 10:40:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 408898. Aggressively SetWindow when paining on Mac with CG to prevent plugins drawing in the wrong place. patch by Matthew Gregan, r+sr=roc

Browse Source
This commit is contained in:
roc+@cs.cmu.edu 2008-02-26 01:09:05 -08:00
parent a48279000e
commit 0bd184f6aa
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
layout/generic/nsObjectFrame.cpp
View File

@ -1269,12 +1269,27 @@ nsObjectFrame::PaintPlugin(nsIRenderingContext& aRenderingContext,
return;
}
// XXXkinetik if gfxQuartzNativeDrawing ever gave us a CGContext other
// than the current one, we would need to pass that to the plugin via
// SetWindow, just assert that they're the same for now
// If gfxQuartzNativeDrawing hands out a CGContext other than the last
// one we passed to the plugin, we need to pass the new one to the
// plugin via SetWindow.
// XXXkinetik it's not necessary to call SetWindow for every paint so
// this should eventually be optimized to only do so when necessary
nsPluginPort* pluginPort = mInstanceOwner->GetPluginPort();
NS_ASSERTION(pluginPort->cgPort.context == cgContext,
"BeginNativeDrawing using different CGContextRef to plugin");
nsCOMPtr<nsIPluginInstance> inst;
GetPluginInstance(*getter_AddRefs(inst));
if (!inst) {
NS_WARNING("null plugin instance during PaintPlugin");
return;
}
nsPluginWindow* window;
mInstanceOwner->GetWindow(window);
if (!window) {
NS_WARNING("null plugin window during PaintPlugin");
return;
}
pluginPort->cgPort.context = cgContext;
window->window = pluginPort;
inst->SetWindow(window);
mInstanceOwner->Paint(aDirtyRect);