Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1554771: Allow reruning tasks not in the full task graph from treeherder; r=Callek

Browse Source 
Rerunning via action (i.e. from treeherder) currently fails for partials, as the
task isn't in the full task graph (since the parameters for the push-task don't
have the partials). Since (at least currently) all tasks not in the full graph
are release tasks, assume that they require reruns, not retriggers, to allow easier
handling of tasks via treeherder.

Differential Revision: https://phabricator.services.mozilla.com/D56516

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Tom Prince 2019-12-12 02:35:18 +00:00
parent 724ba9143c
commit 0bdcc1c550
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
taskcluster/taskgraph/actions/retrigger.py
View File

@ -27,6 +27,22 @@ logger = logging.getLogger(__name__)
RERUN_STATES = ('exception', 'failed')
def _should_retrigger(task_graph, label):
"""
Return whether a given task in the taskgraph should be retriggered.
This handles the case where the task isn't there by assuming it should not be.
"""
if label not in task_graph:
logger.info(
"Task {} not in full taskgraph, assuming task should not be retriggered.".format(
label
)
)
return False
return task_graph[label].attributes.get("retrigger", False)
@register_callback_action(
title='Retrigger',
name='retrigger',
@ -138,7 +154,7 @@ def retrigger_action(parameters, graph_config, input, task_group_id, task_id):
with_downstream = ' '
to_run = [label]
if not input.get('force', None) and not full_task_graph[label].attributes.get('retrigger'):
if not input.get('force', None) and not _should_retrigger(full_task_graph, label):
logger.info(
"Not retriggering task {}, task should not be retrigged "
"and force not specified.".format(
@ -257,10 +273,11 @@ def retrigger_multiple(parameters, graph_config, input, task_group_id, task_id):
times = request.get('times', 1)
rerun_tasks = [
label for label in request.get('tasks')
if not full_task_graph[label].attributes.get('retrigger')]
if not _should_retrigger(full_task_graph, label)
]
retrigger_tasks = [
label for label in request.get('tasks')
if full_task_graph[label].attributes.get('retrigger')
if _should_retrigger(full_task_graph, label)
]
for label in rerun_tasks: