Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-27 04:05:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1563229 - In raptor, only check for crashes after app launched successfully; r=rwood,perftest-reviewers

Browse Source 
This avoids error messages about missing minidump directories when an unrelated failure aborts a run before launching the test app.

Differential Revision: https://phabricator.services.mozilla.com/D36925

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Geoff Brown 2019-07-09 16:54:33 +00:00
parent 558e6e3200
commit 0bf2156985
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
testing/raptor/raptor/raptor.py
View File

@ -724,6 +724,7 @@ class RaptorAndroid(Raptor):
self.os_baseline_data = None
self.screen_off_timeout = 0
self.screen_brightness = 127
self.app_launched = False
def set_reverse_port(self, port):
tcp_port = "tcp:{}".format(port)
@ -1014,6 +1015,7 @@ class RaptorAndroid(Raptor):
if not self.device.process_exist(self.config['binary']):
raise Exception("Error launching %s. App did not start properly!" %
self.config['binary'])
self.app_launched = True
except Exception as e:
LOG.error("Exception launching %s" % self.config['binary'])
LOG.error("Exception: %s %s" % (type(e).__name__, str(e)))
@ -1212,6 +1214,10 @@ class RaptorAndroid(Raptor):
self.runner.wait(timeout=None)
def check_for_crashes(self):
if not self.app_launched:
LOG.info("skipping check_for_crashes: application has not been launched")
return
self.app_launched = False
# Turn off verbose to prevent logcat from being inserted into the main log.
verbose = self.device._verbose
self.device._verbose = False