Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 06:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 836263: Limit max pref size to 1 MB. r=bsmedberg

Browse Source
This commit is contained in:
Kyle Huey 2013-05-01 13:21:23 -07:00
parent 0a74d31358
commit 0c84e0d968
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/libpref/src/nsPrefBranch.cpp
View File

@ -29,6 +29,9 @@
#include "nsICrashReporter.h"
#endif
// 1 MB should be enough for everyone.
static const uint32_t MAX_PREF_LENGTH = 1 * 1024 * 1024;
// Definitions
struct EnumerateData {
const char *parent;
@ -401,10 +404,13 @@ NS_IMETHODIMP nsPrefBranch::SetComplexValue(const char *aPrefName, const nsIID &
nsCOMPtr<nsISupportsString> theString = do_QueryInterface(aValue);
if (theString) {
nsAutoString wideString;
nsString wideString;
rv = theString->GetData(wideString);
if (NS_SUCCEEDED(rv)) {
if (wideString.Length() > MAX_PREF_LENGTH) {
return NS_ERROR_OUT_OF_MEMORY;
}
rv = SetCharPref(aPrefName, NS_ConvertUTF16toUTF8(wideString).get());
}
}
@ -419,6 +425,9 @@ NS_IMETHODIMP nsPrefBranch::SetComplexValue(const char *aPrefName, const nsIID &
rv = theString->GetData(getter_Copies(wideString));
if (NS_SUCCEEDED(rv)) {
if (wideString.Length() > MAX_PREF_LENGTH) {
return NS_ERROR_OUT_OF_MEMORY;
}
rv = SetCharPref(aPrefName, NS_ConvertUTF16toUTF8(wideString).get());
}
}