Bug 1910717 - Remove pref for iterator helpers r=jandem

Differential Revision: https://phabricator.services.mozilla.com/D225287

js/src/shell/js.cpp

@@ -12823,9 +12823,6 @@ bool SetGlobalOptionsPreJSInit(const OptionParser& op) {
   if (op.getBoolOption("enable-float16array")) {
     JS::Prefs::setAtStartup_experimental_float16array(true);
   }
-  if (op.getBoolOption("enable-iterator-helpers")) {
-    JS::Prefs::setAtStartup_experimental_iterator_helpers(true);
-  }
   if (op.getBoolOption("enable-new-set-methods")) {
     JS::Prefs::setAtStartup_experimental_new_set_methods(true);
   }

js/src/vm/GlobalObject.cpp

@@ -109,10 +109,6 @@ JS_PUBLIC_API const JSClass* js::ProtoKeyToClass(JSProtoKey key) {
   return protoTable[key];
 }
 
-static bool IsIteratorHelpersEnabled() {
-  return JS::Prefs::experimental_iterator_helpers();
-}
-
 static bool IsAsyncIteratorHelpersEnabled() {
 #ifdef NIGHTLY_BUILD
   return JS::Prefs::experimental_async_iterator_helpers();
@@ -138,6 +134,7 @@ bool GlobalObject::skipDeselectedConstructor(JSContext* cx, JSProtoKey key) {
     case JSProto_RegExp:
     case JSProto_Error:
     case JSProto_InternalError:
+    case JSProto_Iterator:
     case JSProto_AggregateError:
 #ifdef ENABLE_EXPLICIT_RESOURCE_MANAGEMENT
     case JSProto_SuppressedError:
@@ -248,9 +245,6 @@ bool GlobalObject::skipDeselectedConstructor(JSContext* cx, JSProtoKey key) {
     case JSProto_FinalizationRegistry:
       return JS::GetWeakRefsEnabled() == JS::WeakRefSpecifier::Disabled;
 
-    case JSProto_Iterator:
-      return !IsIteratorHelpersEnabled();
-
     case JSProto_AsyncIterator:
       return !IsAsyncIteratorHelpersEnabled();
 
@@ -1026,11 +1020,6 @@ bool GlobalObject::addIntrinsicValue(JSContext* cx,
 /* static */
 JSObject* GlobalObject::createIteratorPrototype(JSContext* cx,
                                                 Handle<GlobalObject*> global) {
-  if (!IsIteratorHelpersEnabled()) {
-    return getOrCreateBuiltinProto(cx, global, ProtoKind::IteratorProto,
-                                   initIteratorProto);
-  }
-
   if (!ensureConstructor(cx, global, JSProto_Iterator)) {
     return nullptr;
   }

modules/libpref/init/StaticPrefList.yaml

@@ -8069,14 +8069,6 @@
   mirror: always
   set_spidermonkey_pref: startup
 
-
-# Experimental support for Iterator Helpers in JavaScript.
-- name: javascript.options.experimental.iterator_helpers
-  type: bool
-  value: true
-  mirror: always
-  set_spidermonkey_pref: startup
-
 # Experimental support for Pattern Modifiers in JavaScript.
 - name: javascript.options.experimental.regexp_modifiers
   type: bool