Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1723204: Wire up a crash for Javascript Load Telemetry r=ckerschb,Gijs

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D121417
This commit is contained in:
Tom Ritter 2021-08-09 14:42:31 +00:00
parent 4e042e9603
commit 0d2fa9bec2
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dom/security/nsContentSecurityUtils.cpp
View File

@ -1177,6 +1177,18 @@ bool nsContentSecurityUtils::ValidateScriptFilename(const char* aFilename,
Telemetry::RecordEvent(eventType, mozilla::Some(fileNameTypeAndDetails.first),
extra);
#ifdef NIGHTLY_BUILD
// Cause a crash (if we've never crashed before and we can ensure we won't do
// it again.)
// The details in the second arg, passed to UNSAFE_PRINTF, are also included in
// Event Telemetry and have received data review.
if (fileNameTypeAndDetails.second.isSome()) {
PossiblyCrash("js_load_1", NS_ConvertUTF16toUTF8(fileNameTypeAndDetails.second.value()));
} else {
PossiblyCrash("js_load_1", "(None)"_ns);
}
#endif
// Presently we are not enforcing any restrictions for the script filename,
// we're only reporting Telemetry. In the future we will assert in debug
// builds and return false to prevent execution in non-debug builds.

3
modules/libpref/init/all.js
View File

@ -213,6 +213,9 @@ pref("security.osreauthenticator.blank_password", false);
pref("security.osreauthenticator.password_last_changed_lo", 0);
pref("security.osreauthenticator.password_last_changed_hi", 0);
pref("security.crash_tracking.js_load_1.prevCrashes", 0);
pref("security.crash_tracking.js_load_1.maxCrashes", 1);
pref("general.useragent.compatMode.firefox", false);
pref("general.config.obscure_value", 13); // for MCD .cfg files