Backed out changeset a8e3534959ba for incorrect bug number

This commit is contained in:
Chris Peterson 2014-08-09 00:39:31 -07:00
parent 8c2af08eaf
commit 0d513d758b
9 changed files with 18 additions and 18 deletions

View File

@ -30,7 +30,7 @@ ABIArgGenerator::next(MIRType type)
stackOffset_ += sizeof(uint64_t); stackOffset_ += sizeof(uint64_t);
break; break;
default: default:
MOZ_CRASH("Unexpected argument type"); MOZ_ASSUME_UNREACHABLE("Unexpected argument type");
} }
return current_; return current_;
} }

View File

@ -248,7 +248,7 @@ class Assembler : public AssemblerX86Shared
writeDataRelocation(ptr); writeDataRelocation(ptr);
break; break;
default: default:
MOZ_CRASH("unexpected operand kind"); MOZ_ASSUME_UNREACHABLE("unexpected operand kind");
} }
} }
void movl(ImmWord imm, Register dest) { void movl(ImmWord imm, Register dest) {
@ -305,7 +305,7 @@ class Assembler : public AssemblerX86Shared
masm.fld32_m(dest.disp(), dest.base()); masm.fld32_m(dest.disp(), dest.base());
break; break;
default: default:
MOZ_CRASH("unexpected operand kind"); MOZ_ASSUME_UNREACHABLE("unexpected operand kind");
} }
} }
@ -315,7 +315,7 @@ class Assembler : public AssemblerX86Shared
masm.fstp32_m(src.disp(), src.base()); masm.fstp32_m(src.disp(), src.base());
break; break;
default: default:
MOZ_CRASH("unexpected operand kind"); MOZ_ASSUME_UNREACHABLE("unexpected operand kind");
} }
} }
@ -347,7 +347,7 @@ class Assembler : public AssemblerX86Shared
writeDataRelocation(imm); writeDataRelocation(imm);
break; break;
default: default:
MOZ_CRASH("unexpected operand kind"); MOZ_ASSUME_UNREACHABLE("unexpected operand kind");
} }
} }
void cmpl(AsmJSAbsoluteAddress lhs, Register rhs) { void cmpl(AsmJSAbsoluteAddress lhs, Register rhs) {

View File

@ -80,7 +80,7 @@ IonBailoutIterator::IonBailoutIterator(const JitActivationIterator &activations,
switch (mode_) { switch (mode_) {
case SequentialExecution: topIonScript_ = script()->ionScript(); break; case SequentialExecution: topIonScript_ = script()->ionScript(); break;
case ParallelExecution: topIonScript_ = script()->parallelIonScript(); break; case ParallelExecution: topIonScript_ = script()->parallelIonScript(); break;
default: MOZ_CRASH("No such execution mode"); default: MOZ_ASSUME_UNREACHABLE("No such execution mode");
} }
if (bailout->frameClass() == FrameSizeClass::None()) { if (bailout->frameClass() == FrameSizeClass::None()) {

View File

@ -191,7 +191,7 @@ ICBinaryArith_Int32::Compiler::generateStubCode(MacroAssembler &masm)
} }
break; break;
default: default:
MOZ_CRASH("Unhandled op for BinaryArith_Int32."); MOZ_ASSUME_UNREACHABLE("Unhandled op for BinaryArith_Int32. ");
} }
// Return. // Return.
@ -252,7 +252,7 @@ ICUnaryArith_Int32::Compiler::generateStubCode(MacroAssembler &masm)
masm.negl(R0.payloadReg()); masm.negl(R0.payloadReg());
break; break;
default: default:
MOZ_CRASH("Unexpected op"); MOZ_ASSUME_UNREACHABLE("Unexpected op");
} }
EmitReturnFromIC(masm); EmitReturnFromIC(masm);

View File

@ -280,7 +280,7 @@ CodeGeneratorX86::loadViewTypeElement(Scalar::Type vt, const T &srcAddr,
case Scalar::Uint32: masm.movlWithPatch(srcAddr, ToRegister(out)); break; case Scalar::Uint32: masm.movlWithPatch(srcAddr, ToRegister(out)); break;
case Scalar::Float32: masm.movssWithPatch(srcAddr, ToFloatRegister(out)); break; case Scalar::Float32: masm.movssWithPatch(srcAddr, ToFloatRegister(out)); break;
case Scalar::Float64: masm.movsdWithPatch(srcAddr, ToFloatRegister(out)); break; case Scalar::Float64: masm.movsdWithPatch(srcAddr, ToFloatRegister(out)); break;
default: MOZ_CRASH("unexpected array type"); default: MOZ_ASSUME_UNREACHABLE("unexpected array type");
} }
} }
@ -385,7 +385,7 @@ CodeGeneratorX86::storeViewTypeElement(Scalar::Type vt, const LAllocation *value
case Scalar::Uint32: masm.movlWithPatch(ToRegister(value), dstAddr); break; case Scalar::Uint32: masm.movlWithPatch(ToRegister(value), dstAddr); break;
case Scalar::Float32: masm.movssWithPatch(ToFloatRegister(value), dstAddr); break; case Scalar::Float32: masm.movssWithPatch(ToFloatRegister(value), dstAddr); break;
case Scalar::Float64: masm.movsdWithPatch(ToFloatRegister(value), dstAddr); break; case Scalar::Float64: masm.movsdWithPatch(ToFloatRegister(value), dstAddr); break;
default: MOZ_CRASH("unexpected array type"); default: MOZ_ASSUME_UNREACHABLE("unexpected array type");
} }
} }
@ -544,7 +544,7 @@ DispatchIonCache::initializeAddCacheState(LInstruction *ins, AddCacheState *addS
{ {
// On x86, where there is no general purpose scratch register available, // On x86, where there is no general purpose scratch register available,
// child cache classes must manually specify a dispatch scratch register. // child cache classes must manually specify a dispatch scratch register.
MOZ_CRASH("x86 needs manual assignment of dispatchScratch"); MOZ_ASSUME_UNREACHABLE("x86 needs manual assignment of dispatchScratch");
} }
void void

View File

@ -254,7 +254,7 @@ LIRGeneratorX86::visitAsmJSStoreHeap(MAsmJSStoreHeap *ins)
// See comment below. // See comment below.
lir = new(alloc()) LAsmJSStoreHeap(ptrAlloc, useRegisterAtStart(ins->value())); lir = new(alloc()) LAsmJSStoreHeap(ptrAlloc, useRegisterAtStart(ins->value()));
break; break;
default: MOZ_CRASH("unexpected array type"); default: MOZ_ASSUME_UNREACHABLE("unexpected array type");
} }
return add(lir, ins); return add(lir, ins);
} }
@ -271,7 +271,7 @@ LIRGeneratorX86::visitAsmJSStoreHeap(MAsmJSStoreHeap *ins)
// affects instruction layout which affects patching. // affects instruction layout which affects patching.
lir = new(alloc()) LAsmJSStoreHeap(useRegisterAtStart(ptr), useRegisterAtStart(ins->value())); lir = new(alloc()) LAsmJSStoreHeap(useRegisterAtStart(ptr), useRegisterAtStart(ins->value()));
break; break;
default: MOZ_CRASH("unexpected array type"); default: MOZ_ASSUME_UNREACHABLE("unexpected array type");
} }
return add(lir, ins); return add(lir, ins);
@ -295,7 +295,7 @@ LIRGeneratorX86::visitStoreTypedArrayElementStatic(MStoreTypedArrayElementStatic
lir = new(alloc()) LStoreTypedArrayElementStatic(useRegisterAtStart(ins->ptr()), lir = new(alloc()) LStoreTypedArrayElementStatic(useRegisterAtStart(ins->ptr()),
useRegisterAtStart(ins->value())); useRegisterAtStart(ins->value()));
break; break;
default: MOZ_CRASH("unexpected array type"); default: MOZ_ASSUME_UNREACHABLE("unexpected array type");
} }
return add(lir, ins); return add(lir, ins);

View File

@ -173,7 +173,7 @@ MacroAssemblerX86::passABIArg(const MoveOperand &from, MoveOp::Type type)
case MoveOp::DOUBLE: stackForCall_ += sizeof(double); break; case MoveOp::DOUBLE: stackForCall_ += sizeof(double); break;
case MoveOp::INT32: stackForCall_ += sizeof(int32_t); break; case MoveOp::INT32: stackForCall_ += sizeof(int32_t); break;
case MoveOp::GENERAL: stackForCall_ += sizeof(intptr_t); break; case MoveOp::GENERAL: stackForCall_ += sizeof(intptr_t); break;
default: MOZ_CRASH("Unexpected argument type"); default: MOZ_ASSUME_UNREACHABLE("Unexpected argument type");
} }
enoughMemory_ &= moveResolver_.addMove(from, to, type); enoughMemory_ &= moveResolver_.addMove(from, to, type);
} }

View File

@ -102,7 +102,7 @@ class MacroAssemblerX86 : public MacroAssemblerX86Shared
base.scale(), base.disp() + sizeof(void *)); base.scale(), base.disp() + sizeof(void *));
default: default:
MOZ_CRASH("unexpected operand kind"); MOZ_ASSUME_UNREACHABLE("unexpected operand kind");
} }
} }
Address ToType(Address base) { Address ToType(Address base) {

View File

@ -575,7 +575,7 @@ JitRuntime::generateBailoutHandler(JSContext *cx, ExecutionMode mode)
GenerateParallelBailoutThunk(masm, NO_FRAME_SIZE_CLASS_ID); GenerateParallelBailoutThunk(masm, NO_FRAME_SIZE_CLASS_ID);
break; break;
default: default:
MOZ_CRASH("No such execution mode"); MOZ_ASSUME_UNREACHABLE("No such execution mode");
} }
Linker linker(masm); Linker linker(masm);
@ -711,7 +711,7 @@ JitRuntime::generateVMWrapper(JSContext *cx, const VMFunction &f)
masm.j(Assembler::Zero, masm.failureLabel(f.executionMode)); masm.j(Assembler::Zero, masm.failureLabel(f.executionMode));
break; break;
default: default:
MOZ_CRASH("unknown failure kind"); MOZ_ASSUME_UNREACHABLE("unknown failure kind");
} }
// Load the outparam and free any allocated stack. // Load the outparam and free any allocated stack.