Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1598164 - Improved test assertion messages and removed code duplication. r=dom-workers-and-storage-reviewers,edenchuang

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D54266

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Simon Giesecke 2019-11-26 12:02:21 +00:00
parent 4dafd4e9c2
commit 0d6f5cd8de
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
dom/indexedDB/test/unit/test_keys.js
View File

@ -293,30 +293,33 @@ function* testSteps() {
[1, [{}]],
];
function checkInvalidKeyException(ex, i, callText) {
let suffix = ` during ${callText} with invalid key ${i}: "${
invalidKeys[i]
}"`;
ok(ex instanceof DOMException, "Threw DOMException" + suffix);
is(ex.name, "DataError", "Threw right DOMException" + suffix);
is(ex.code, 0, "Threw with right code" + suffix);
}
for (i = 0; i < invalidKeys.length; ++i) {
try {
indexedDB.cmp(invalidKeys[i], 1);
ok(false, "didn't throw");
} catch (ex) {
ok(ex instanceof DOMException, "Threw DOMException");
is(ex.name, "DataError", "Threw right DOMException");
is(ex.code, 0, "Threw with right code");
checkInvalidKeyException(ex, i, "cmp(invalidKeys[i], 1)");
}
try {
indexedDB.cmp(1, invalidKeys[i]);
ok(false, "didn't throw2");
} catch (ex) {
ok(ex instanceof DOMException, "Threw DOMException2");
is(ex.name, "DataError", "Threw right DOMException2");
is(ex.code, 0, "Threw with right code2");
checkInvalidKeyException(ex, i, "cmp(1, invalidKeys[i])");
}
try {
store.put(1, invalidKeys[i]);
ok(false, "didn't throw3");
} catch (ex) {
ok(ex instanceof DOMException, "Threw DOMException3");
is(ex.name, "DataError", "Threw right DOMException3");
is(ex.code, 0, "Threw with right code3");
checkInvalidKeyException(ex, i, "store.put(1, invalidKeys[i])");
}
}