Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-25 19:25:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1459301 - 4. Follow up to fix tests for local runs; r=me

Browse Source 
Manually turn off the popup blocker for all link-clicking tests so local
runs of the tests pass.
This commit is contained in:
Jim Chen 2018-05-15 16:44:15 -04:00
parent d0ba1c83de
commit 0d7a720986
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt
View File

@ -373,6 +373,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test fun onNewSession_calledForTargetBlankLink() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()
@ -410,6 +413,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test fun onNewSession_childShouldLoad() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()
@ -432,6 +438,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test fun onNewSession_setWindowOpener() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()
@ -446,6 +455,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test fun onNewSession_supportNoOpener() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()
@ -459,6 +471,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test fun onNewSession_notCalledForHandledLoads() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()
@ -491,6 +506,9 @@ class NavigationDelegateTest : BaseSessionTest() {
@WithDevToolsAPI
@Test(expected = IllegalArgumentException::class)
fun onNewSession_doesNotAllowOpened() {
// Disable popup blocker.
sessionRule.setPrefsUntilTestEnd(mapOf("dom.disable_open_during_load" to false))
sessionRule.session.loadTestPath(NEW_SESSION_HTML_PATH)
sessionRule.session.waitForPageStop()