Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1319026 - Remove logging for failed Telemetry send requests. r=gfritzsche

Browse Source 
We have the data we need.

MozReview-Commit-ID: 8L24RSiu7Xd
This commit is contained in:
Chris H-C 2017-05-19 09:05:00 -04:00
parent 590b8f81b4
commit 0f37025fc8
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
toolkit/components/telemetry/TelemetrySend.jsm
View File

@ -39,8 +39,6 @@ XPCOMUtils.defineLazyModuleGetter(this, "OS",
XPCOMUtils.defineLazyServiceGetter(this, "Telemetry",
"@mozilla.org/base/telemetry;1",
"nsITelemetry");
XPCOMUtils.defineLazyModuleGetter(this, "TelemetryLog",
"resource://gre/modules/TelemetryLog.jsm");
const Utils = TelemetryUtils;
@ -94,9 +92,6 @@ const SEND_MAXIMUM_BACKOFF_DELAY_MS = 120 * MS_IN_A_MINUTE;
// The age of a pending ping to be considered overdue (in milliseconds).
const OVERDUE_PING_FILE_AGE = 7 * 24 * 60 * MS_IN_A_MINUTE; // 1 week
// TelemetryLog Key for logging failures to send Telemetry
const LOG_FAILURE_KEY = "TELEMETRY_SEND_FAILURE";
function monotonicNow() {
try {
return Telemetry.msSinceProcessStart();
@ -1112,7 +1107,6 @@ var TelemetrySendImpl = {
};
let errorhandler = (event) => {
TelemetryLog.log(LOG_FAILURE_KEY, ["errorhandler", event.type]);
this._log.error("_doPing - error making request to " + url + ": " + event.type);
onRequestFinished(false, event);
};
@ -1136,18 +1130,15 @@ var TelemetrySendImpl = {
Telemetry.getHistogramById("TELEMETRY_PING_EVICTED_FOR_SERVER_ERRORS").add();
// TODO: we should handle this better, but for now we should avoid resubmitting
// broken requests by pretending success.
TelemetryLog.log(LOG_FAILURE_KEY, ["4xx 'failure'", status]);
success = true;
} else if (statusClass === 500) {
// 5XX means there was a server-side error and we should try again later.
this._log.error("_doPing - error submitting to " + url + ", status: " + status
+ " - server error, should retry later");
TelemetryLog.log(LOG_FAILURE_KEY, ["5xx failure", status]);
} else {
// We received an unexpected status code.
this._log.error("_doPing - error submitting to " + url + ", status: " + status
+ ", type: " + event.type);
TelemetryLog.log(LOG_FAILURE_KEY, ["Unhandled HTTP failure", status]);
}
onRequestFinished(success, event);

4
toolkit/components/telemetry/docs/data/main-ping.rst
View File

@ -415,12 +415,10 @@ Structure:
...
]
At present there are two known users of this section: Telemetry Experiments and TelemetrySend.
At present there is one known users of this section: Telemetry Experiments.
Telemetry Experiments uses it to note when experiments are activated and terminated.
TelemetrySend uses it to record failures when sending Telemetry pings.
webrtc
------
Contains special statistics gathered by WebRTC related components.