Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 610491: Preemptively stop SVG animations in SVG-as-an-image in OnStartRequest. r=roc a=roc

Browse Source
This commit is contained in:
Daniel Holbert 2010-11-16 10:35:59 -08:00
parent 4a5f0f7ac1
commit 0f8a89b3b5
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
layout/reftests/svg/as-image/lime-anim-100x100.svg
View File

@ -1,5 +1,6 @@
<svg xmlns="http://www.w3.org/2000/svg" version="1.1"
width="100" height="100">
<rect width="100%" height="100%" fill="red"/>
<rect x="-600" width="100%" height="100%" fill="lime">
<animate attributeName="x" by="600" dur="0.001" fill="freeze"/>
</rect>

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 227 B

After

Width:  |  Height:  |  Size: 275 B

2
modules/libpr0n/src/SVGDocumentWrapper.cpp
View File

@ -251,6 +251,8 @@ SVGDocumentWrapper::OnStartRequest(nsIRequest* aRequest, nsISupports* ctxt)
if (NS_SUCCEEDED(rv) &&
NS_SUCCEEDED(mListener->OnStartRequest(aRequest, nsnull))) {
mViewer->GetDocument()->SetIsBeingUsedAsImage();
StopAnimation(); // otherwise animations start automatically in helper doc
rv = mViewer->Init(nsnull, nsIntRect(0, 0, 0, 0));
if (NS_SUCCEEDED(rv)) {
rv = mViewer->Open(nsnull, nsnull);

6
modules/libpr0n/src/VectorImage.cpp
View File

@ -696,12 +696,6 @@ VectorImage::OnStopRequest(nsIRequest* aRequest, nsISupports* aCtxt,
mIsFullyLoaded = PR_TRUE;
mHaveAnimations = mSVGDocumentWrapper->IsAnimated();
if (mHaveAnimations && mAnimationMode == kDontAnimMode) {
// We're not supposed to be animating -- stop any animation before our
// SVG document's timeline gets a chance to progress.
mSVGDocumentWrapper->StopAnimation();
}
#ifdef MOZ_ENABLE_LIBXUL
// Start listening to our image for rendering updates
mRenderingObserver = new SVGRootRenderingObserver(mSVGDocumentWrapper, this);