Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1285373 P1 Allow addon-sdk unloader to hold callbacks weakly. r=gabor

Browse Source
This commit is contained in:
Ben Kelly 2016-07-20 06:47:23 -07:00
parent 499efe0f10
commit 104a1642b5
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
addon-sdk/source/lib/sdk/system/unload.js
View File

@ -10,16 +10,33 @@ module.metadata = {
"stability": "experimental"
};
const { Cu } = require('chrome');
const { on, off } = require('./events');
const unloadSubject = require('@loader/unload');
const observers = [];
const unloaders = [];
var when = exports.when = function when(observer) {
if (observers.indexOf(observer) != -1)
return;
observers.unshift(observer);
function WeakObserver(inner) {
this._inner = Cu.getWeakReference(inner);
}
Object.defineProperty(WeakObserver.prototype, 'value', {
get: function() { this._inner.get() }
});
var when = exports.when = function when(observer, opts) {
opts = opts || {};
for (var i = 0; i < observers.length; ++i) {
if (observers[i] === observer || observers[i].value === observer) {
return;
}
}
if (opts.weak) {
observers.unshift(new WeakObserver(observer));
} else {
observers.unshift(observer);
}
};
var ensure = exports.ensure = function ensure(obj, destructorName) {
@ -55,7 +72,12 @@ var ensure = exports.ensure = function ensure(obj, destructorName) {
function unload(reason) {
observers.forEach(function(observer) {
try {
observer(reason);
if (observer instanceof WeakObserver) {
observer = observer.value;
}
if (typeof observer === 'function') {
observer(reason);
}
}
catch (error) {
console.exception(error);