Bug 1186834 - fix flake8 issues on talos. r=jmaher

--HG--
extra : commitid : 9n5csR4qtv
extra : rebase_source : c83f9d7c842966a222bdce2fe18943e582b71975
This commit is contained in:
Julien Pagès 2015-11-23 17:05:45 +01:00
parent 8a04abb7cc
commit 1157ce7802
6 changed files with 13 additions and 10 deletions

View File

@ -186,4 +186,3 @@ def v8_subtest(series, name):
}
return reference[name] / geometric_mean(series)

View File

@ -449,7 +449,8 @@ class PerfherderOutput(Output):
vals = []
replicates = {}
# TODO: counters!!!! we don't have any, but they suffer the same
# TODO: counters!!!! we don't have any, but they suffer the
# same
for result in test.results:
# XXX this will not work for manifests which list
# the same page name twice. It also ignores cycles
@ -484,7 +485,8 @@ class PerfherderOutput(Output):
}
subtests.append(subtest)
if test.test_config.get('lower_is_better') is not None:
subtest['lowerIsBetter'] = test.test_config['lower_is_better']
subtest['lowerIsBetter'] = \
test.test_config['lower_is_better']
if test.test_config.get('unit'):
subtest['unit'] = test.test_config['unit']
@ -493,7 +495,8 @@ class PerfherderOutput(Output):
suite['value'] = self.construct_results(
vals, testname=test.name())
if test.test_config.get('lower_is_better') is not None:
suite['lowerIsBetter'] = test.test_config['lower_is_better']
suite['lowerIsBetter'] = \
test.test_config['lower_is_better']
# counters results_aux data
counter_subtests = []
@ -524,7 +527,8 @@ class PerfherderOutput(Output):
varray = [float(v) for v in vals]
subtest['value'] = filter.mean(varray)
if counter_subtests:
suites.append({'name': test.name(), 'subtests': counter_subtests})
suites.append({'name': test.name(),
'subtests': counter_subtests})
return test_results
# available output formats

View File

@ -167,7 +167,7 @@ class Results(object):
data = f.apply(data)
summary = {
'filtered': data, # for backwards compatibility with perfherder
'filtered': data, # backward compatibility with perfherder
'value': data
}

View File

@ -5,7 +5,6 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
import mozversion
import mozfile
import logging
import os
import sys
@ -195,7 +194,8 @@ def run_tests(config, browser_config):
mytest = TTest()
talos_results.add(mytest.runTest(browser_config, test))
logging.info("Completed test %s (%s)", testname, testtimer.elapsed())
logging.info("Completed test %s (%s)", testname,
testtimer.elapsed())
except TalosRegression:
logging.error("Detected a regression for %s", testname)

View File

@ -5,7 +5,6 @@
"""Utility functions for Talos"""
import os
import sys
import time
import urlparse
import string

View File

@ -455,7 +455,8 @@ def etlparser(xperf_path, etl_filename, processID, approot=None,
with open(error_filename, 'w') as errorFile:
errorFile.write('\n'.join(errors))
# TODO: commented this out from bug 1205005, we have a memory error in blobber upload
# TODO: commented this out from bug 1205005, we have a memory error in blobber
# upload
# mud = os.environ.get('MOZ_UPLOAD_DIR', None)
# if mud:
# mud_filename = os.path.join(mud, etl_filename)