Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-26 23:23:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 793866 - Missing null check in mozInlineSpellChecker::UpdateCurrentDictionary(); r=ehsan

Browse Source
This commit is contained in:
Aryeh Gregor 2012-10-10 09:05:16 +02:00
parent 4766ff4681
commit 117e69b7e2
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
editor/libeditor/html/crashtests/793866.html Normal file
View File

@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<head>
<script>
function boom()
{
var b = document.body;
b.contentEditable = "true";
document.execCommand("contentReadOnly", false, null);
b.focus();
b.contentEditable = "false";
document.documentElement.contentEditable = "true";
document.createDocumentFragment().appendChild(b);
document.documentElement.focus();
}
</script>
</head>
<body onload="boom();"></body>
</html>

1
editor/libeditor/html/crashtests/crashtests.list
View File

@ -35,3 +35,4 @@ load 766795.html
load 767169.html
load 769967.xhtml
load 768748.html
needs-focus load 793866.html

4
extensions/spellcheck/src/mozInlineSpellChecker.cpp
View File

@ -1780,10 +1780,12 @@ NS_IMETHODIMP mozInlineSpellChecker::UpdateCurrentDictionary()
previousDictionary.Truncate();
}
// This might set mSpellCheck to null (bug 793866)
nsresult rv = mSpellCheck->UpdateCurrentDictionary();
nsAutoString currentDictionary;
if (NS_FAILED(mSpellCheck->GetCurrentDictionary(currentDictionary))) {
if (!mSpellCheck ||
NS_FAILED(mSpellCheck->GetCurrentDictionary(currentDictionary))) {
currentDictionary.Truncate();
}