Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 07:13:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1189531 - Check for nullptr in convertTimeToDate. r=gerald

Browse Source 
In current code it's not possible to pass nullptr, but there's
no harm in checking.

See also bug 1156891.
This commit is contained in:
Ralph Giles 2015-11-04 14:43:00 -08:00
parent 75e08b8620
commit 11afc76455
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
View File

@ -726,8 +726,11 @@ static bool underMetaDataPath(const nsTArray<uint32_t> &path) {
// Given a time in seconds since Jan 1 1904, produce a human-readable string.
static bool convertTimeToDate(int64_t time_1904, String8 *s) {
time_t time_1970 = time_1904 - (((66 * 365 + 17) * 24) * 3600);
if (!s) {
return false;
}
time_t time_1970 = time_1904 - (((66 * 365 + 17) * 24) * 3600);
if (time_1970 < 0) {
return false;
}