Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-16 13:56:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1492335 - Strip view-source prefix when copying/sharing links from context menu. r=snorp

Browse Source 
Desktop does this when copying link URLs and sharing is just effectively just
another form of copying.
For completeness, we also apply this when "viewing" the source of images (which
just displays the image itself anyway).

No special handling is required for other media elements (audio/video), because
looking at those in view-source mode does display the raw file contents and
thus none of the media-specific context menu entries will show up.

Differential Revision: https://phabricator.services.mozilla.com/D15381

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jan Henning 2018-12-26 18:38:18 +00:00
parent f13008dfac
commit 120b216df7
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mobile/android/chrome/content/browser.js
View File

@ -650,6 +650,7 @@ var BrowserApp = {
UITelemetry.addEvent("action.1", "contextmenu", null, "web_copy_link");
let url = NativeWindow.contextmenus._getLinkURL(aTarget);
url = NativeWindow.contextmenus._stripViewSource(url);
NativeWindow.contextmenus._copyStringToDefaultClipboard(url);
});
@ -678,9 +679,11 @@ var BrowserApp = {
order: NativeWindow.contextmenus.DEFAULT_HTML5_ORDER - 1, // Show above HTML5 menu items
selector: NativeWindow.contextmenus._disableRestricted("SHARE", NativeWindow.contextmenus.linkShareableContext),
showAsActions: function(aElement) {
let uri = NativeWindow.contextmenus._getLinkURL(aElement);
uri = NativeWindow.contextmenus._stripViewSource(uri);
return {
title: aElement.textContent.trim() || aElement.title.trim(),
uri: NativeWindow.contextmenus._getLinkURL(aElement),
uri,
};
},
icon: "drawable://ic_menu_share",
@ -854,6 +857,7 @@ var BrowserApp = {
UITelemetry.addEvent("action.1", "contextmenu", null, "web_copy_image");
let url = aTarget.src;
url = NativeWindow.contextmenus._stripViewSource(url);
NativeWindow.contextmenus._copyStringToDefaultClipboard(url);
});
@ -863,6 +867,7 @@ var BrowserApp = {
order: NativeWindow.contextmenus.DEFAULT_HTML5_ORDER - 1, // Show above HTML5 menu items
showAsActions: function(aTarget) {
let src = aTarget.src;
src = NativeWindow.contextmenus._stripViewSource(src);
return {
title: src,
uri: src,
@ -3233,6 +3238,11 @@ var NativeWindow = {
_stripScheme: function(aString) {
let index = aString.indexOf(":");
return aString.slice(index + 1);
},
_stripViewSource: function(aString) {
// If we're in a view source tab, remove the view-source: prefix
return aString.replace(/^view-source:/, "");
}
}
};