Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixes bug 296163 "PAC files containing non-ASCII text (comments) fail to load." r=biesi a=asa

Browse Source
This commit is contained in:
darin%meer.net 2005-06-20 17:47:38 +00:00
parent 08464ff71a
commit 12c1b15b09
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
netwerk/base/src/nsPACMan.cpp
View File

@ -373,16 +373,11 @@ nsPACMan::OnStreamComplete(nsIStreamLoader *loader,
NS_WARNING("failed to instantiate PAC component");
}
if (NS_SUCCEEDED(status)) {
// We assume that the PAC text is ASCII. We've had this assumption
// forever, so no reason to change this now.
// We assume that the PAC text is ASCII (or ISO-Latin-1). We've had this
// assumption forever, and some real-world PAC scripts actually have some
// non-ASCII text in comment blocks (see bug 296163).
const char *text = (const char *) data;
if (!nsCRT::IsAscii(text, dataLen)) {
NS_WARNING("PAC text is not ASCII");
status = NS_ERROR_UNEXPECTED;
}
else {
status = mPAC->Init(pacURI, NS_ConvertASCIItoUTF16(text, dataLen));
}
status = mPAC->Init(pacURI, NS_ConvertASCIItoUTF16(text, dataLen));
}
}