Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-08 07:53:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 488596 - test_crashreporter.js crashes intermittently: delete the exception handler before freeing the data it references, landing as a bustage fix with presumed-r=ted

Browse Source
This commit is contained in:
Benjamin Smedberg 2009-07-23 11:23:19 -04:00
parent dd6c28f49f
commit 130d269b96
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
toolkit/crashreporter/nsExceptionHandler.cpp
View File

@ -656,6 +656,8 @@ nsresult SetupExtraData(nsILocalFile* aAppDataDirectory,
nsresult UnsetExceptionHandler() nsresult UnsetExceptionHandler()
{ {
delete gExceptionHandler;
// do this here in the unlikely case that we succeeded in allocating // do this here in the unlikely case that we succeeded in allocating
// our strings but failed to allocate gExceptionHandler. // our strings but failed to allocate gExceptionHandler.
if (crashReporterAPIData_Hash) { if (crashReporterAPIData_Hash) {
@ -681,7 +683,6 @@ nsresult UnsetExceptionHandler()
if (!gExceptionHandler) if (!gExceptionHandler)
return NS_ERROR_NOT_INITIALIZED; return NS_ERROR_NOT_INITIALIZED;
delete gExceptionHandler;
gExceptionHandler = nsnull; gExceptionHandler = nsnull;
return NS_OK; return NS_OK;