From 1335b7696c86e9659db5767dc22691ba1e7b94ff Mon Sep 17 00:00:00 2001 From: "jay@mozilla.org" Date: Fri, 1 Feb 2008 17:02:53 -0800 Subject: [PATCH] [Bug 397573] - Make QAX resizeable + other UI fixes --- .../community/chrome/content/litmus.js | 26 +-- .../extensions/community/chrome/content/qa.js | 2 +- .../community/chrome/content/qa.xul | 26 ++- .../community/chrome/content/settings.js | 5 +- .../community/chrome/content/tabs/bugzilla.js | 3 +- .../chrome/content/tabs/bugzilla.xul | 88 +++++------ .../community/chrome/content/tabs/chat.xul | 38 +++-- .../community/chrome/content/tabs/help.xul | 7 +- .../community/chrome/content/tabs/litmus.xul | 148 +++++++++--------- .../community/chrome/content/tabs/qmo.js | 6 +- .../community/chrome/content/tabs/qmo.xul | 31 ++-- .../chrome/content/tabs/settings.xul | 33 ++-- .../community/chrome/locale/en-US/qa.dtd | 61 ++++---- .../chrome/locale/en-US/qa.properties | 4 +- .../extensions/community/chrome/skin/qa.css | 17 +- 15 files changed, 249 insertions(+), 246 deletions(-) diff --git a/testing/extensions/community/chrome/content/litmus.js b/testing/extensions/community/chrome/content/litmus.js index 50bd3580dbfe..1b51895e04e3 100755 --- a/testing/extensions/community/chrome/content/litmus.js +++ b/testing/extensions/community/chrome/content/litmus.js @@ -96,8 +96,8 @@ }, handleDialog : function() { - if ($("qa-testrun-label").value != "") { - litmus.lastTestRunSummary = $("qa-testrun-label").value; + if ($("qa-testrun-label").label != "") { + litmus.lastTestRunSummary = $("qa-testrun-label").label; litmus.lastTestGroupSummary = $("qa-testgroup-label").value; lastTestcaseIndex = $("testlist").selectedIndex; } @@ -113,7 +113,7 @@ if (litmus.lastTestRunSummary == "") return; // this code is v. similar to readStateFromPref, but without an async call. - $("qa-testrun-label").value = litmus.lastTestRunSummary; + $("qa-testrun-label").label = litmus.lastTestRunSummary; $("qa-testgroup-label").value = litmus.lastTestGroupSummary; litmus.lastSubgroupObject = litmus.preDialogueSubgroupObject; litmus.lastTestcaseObject = litmus.preDialogTestcaseObject; @@ -173,7 +173,7 @@ qaPref.setPref(qaPref.prefBase + ".currentTestcase.testcaseIndex", index, "int"); }, readStateFromPref : function() { - $("qa-testrun-label").value = qaPref.getPref(qaPref.prefBase + ".currentTestcase.testrunSummary", "char"); + $("qa-testrun-label").label = qaPref.getPref(qaPref.prefBase + ".currentTestcase.testrunSummary", "char"); $("qa-testgroup-label").value = qaPref.getPref(qaPref.prefBase + ".currentTestcase.testgroupSummary", "char"); litmus.currentSubgroupID = qaPref.getPref(qaPref.prefBase + ".currentTestcase.subgroupId", "int"); litmus.disableAll(); @@ -222,7 +222,7 @@ litmus.disableAll(); litmus.getTestcase($("testlist").selectedItem.value, function(testcase) { litmus.populateTestcase(testcase); - $('qa-testcase-progress').value = + $('qa-testcase-progress').label = qaMain.bundle.getFormattedString('qa.extension.litmus.progress', [$("testlist").selectedIndex+1, $("testlist").getRowCount()]); litmus.undisableAll(); @@ -238,29 +238,33 @@ }; for (var i = 0; i < testcases.length; i++) { - var row = document.createElement("listitem"); + var row = document.createElement("richlistitem"); row.value = testcases[i].testcase_id; + var checkbox = document.createElement("listcell"); checkbox.setAttribute("label", ""); checkbox.setAttribute("type", "checkbox"); checkbox.setAttribute("disabled", "true"); + var name = document.createElement("listcell"); name.setAttribute("label", (i+1) + " -- " + testcases[i].summary); name.setAttribute("crop", "end"); - name.setAttribute("maxwidth", "175"); + name.setAttribute("flex", "1"); + row.appendChild(checkbox); row.appendChild(name); menu.appendChild(row); - } + } + }, populateTestcase : function(testcase) { litmus.lastTestcaseObject = testcase; if (testcase == undefined) { return; } - document.getElementById('qa-testcase-id').value = - qaMain.bundle.getString("qa.extension.testcase.head")+testcase.testcase_id; - document.getElementById('qa-testcase-summary').value = testcase.summary; + document.getElementById('qa-testcase-id').value = "(" + + qaMain.bundle.getString("qa.extension.testcase.head")+testcase.testcase_id + ")"; + document.getElementById('qa-testcase-summary').value = testcase.summary; qaTools.writeSafeHTML('qa-testcase-steps', testcase.steps_formatted); qaTools.writeSafeHTML('qa-testcase-expected', testcase.expected_results_formatted); diff --git a/testing/extensions/community/chrome/content/qa.js b/testing/extensions/community/chrome/content/qa.js index 9306cfc97e4b..b7cf07b3d769 100755 --- a/testing/extensions/community/chrome/content/qa.js +++ b/testing/extensions/community/chrome/content/qa.js @@ -40,7 +40,7 @@ var qaMain = { openQATool : function() { window.open("chrome://qa/content/qa.xul", "_blank", - "chrome,all,dialog=no,resizable=no"); + "chrome,all,dialog=no,resizable=yes"); }, onToolOpen : function() { if (qaPref.getPref(qaPref.prefBase+'.isFirstTime', 'bool') == true) { diff --git a/testing/extensions/community/chrome/content/qa.xul b/testing/extensions/community/chrome/content/qa.xul index 754d2d87741d..7ff625a480d5 100644 --- a/testing/extensions/community/chrome/content/qa.xul +++ b/testing/extensions/community/chrome/content/qa.xul @@ -53,8 +53,8 @@ @@ -84,26 +84,24 @@ }, false); - + - + - - - - - - - - - - + + + + + + + + diff --git a/testing/extensions/community/chrome/content/settings.js b/testing/extensions/community/chrome/content/settings.js index df760e1c832e..bddbf77ed7ca 100755 --- a/testing/extensions/community/chrome/content/settings.js +++ b/testing/extensions/community/chrome/content/settings.js @@ -60,7 +60,7 @@ var qaPrefsWindow = { prefCounter++; } } - }, + }, savePrefsWindow : function() { // save notification settings var notify = $('qa-prefs-notify').childNodes; @@ -216,11 +216,10 @@ var qaSetup = { litmus.validateLogin(uname, passwd, callback); return false; // not ready to advance yet }, - + loadSysconfig : function() { $('qa-setup-sysconfig-loading').value = $("bundle_qa").getString("qa.extension.sysconfig.loadingMsg"); - var guessInfo = function() { var sysconfig; try { diff --git a/testing/extensions/community/chrome/content/tabs/bugzilla.js b/testing/extensions/community/chrome/content/tabs/bugzilla.js index d33782386b11..286c0abf86c7 100644 --- a/testing/extensions/community/chrome/content/tabs/bugzilla.js +++ b/testing/extensions/community/chrome/content/tabs/bugzilla.js @@ -86,7 +86,7 @@ var bugzilla = { var name = document.createElement("listcell"); name.setAttribute("label", bugarray[i][1]); name.setAttribute("crop", "end"); - name.setAttribute("maxwidth", "175"); + name.setAttribute("flex", "1"); row.appendChild(number); row.appendChild(name); menu.appendChild(row); @@ -121,7 +121,6 @@ var bugzilla = { var name = document.createElement("listcell"); name.setAttribute("label", bugObj["title"]); name.setAttribute("crop", "end"); - name.setAttribute("maxwidth", "175"); row.appendChild(number); row.appendChild(name); menu.appendChild(row); diff --git a/testing/extensions/community/chrome/content/tabs/bugzilla.xul b/testing/extensions/community/chrome/content/tabs/bugzilla.xul index b60cc564c1ac..d1e9333ebbfd 100644 --- a/testing/extensions/community/chrome/content/tabs/bugzilla.xul +++ b/testing/extensions/community/chrome/content/tabs/bugzilla.xul @@ -43,74 +43,74 @@ xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml"> - +