Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1847574 - Skip pivot language checking on non-debug builds; r=nordzilla

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D185585
This commit is contained in:
Greg Tatum 2023-08-08 16:25:44 +00:00
parent 87163b5af7
commit 1465317790
2 changed files with 44 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
toolkit/components/translations/actors/TranslationsParent.sys.mjs
View File

@ -1251,6 +1251,11 @@ export class TranslationsParent extends JSWindowActorParent {
* @param {TranslationModelRecord[] | LanguagePair[]} records
*/
static ensureLanguagePairsHavePivots(records) {
if (!AppConstants.DEBUG) {
// Only run this check on debug builds as it's in the performance critical first
// page load path.
return records;
}
// lang -> pivot
const hasToPivot = new Set();
// pivot -> en

61
toolkit/components/translations/tests/browser/browser_translations_actor.js
View File

@ -17,18 +17,27 @@ add_task(async function test_pivot_language_behavior() {
"Expect 4 console.error messages notifying of the lack of a pivot language."
);
const fromLanguagePairs = [
{ fromLang: "en", toLang: "es" },
{ fromLang: "es", toLang: "en" },
{ fromLang: "en", toLang: "yue" },
{ fromLang: "yue", toLang: "en" },
// This is not a bi-directional translation.
{ fromLang: "is", toLang: "en" },
// These are non-pivot languages.
{ fromLang: "zh", toLang: "ja" },
{ fromLang: "ja", toLang: "zh" },
];
// Sort the language pairs, as the order is not guaranteed.
function sort(list) {
return list.sort((a, b) =>
`${a.fromLang}-${a.toLang}`.localeCompare(`${b.fromLang}-${b.toLang}`)
);
}
const { cleanup } = await setupActorTest({
languagePairs: [
{ fromLang: "en", toLang: "es" },
{ fromLang: "es", toLang: "en" },
{ fromLang: "en", toLang: "yue" },
{ fromLang: "yue", toLang: "en" },
// This is not a bi-directional translation.
{ fromLang: "is", toLang: "en" },
// These are non-pivot languages.
{ fromLang: "zh", toLang: "ja" },
{ fromLang: "ja", toLang: "zh" },
],
languagePairs: fromLanguagePairs,
});
const { languagePairs } = await TranslationsParent.getSupportedLanguages();
@ -40,17 +49,25 @@ add_task(async function test_pivot_language_behavior() {
)
);
Assert.deepEqual(
languagePairs,
[
{ fromLang: "en", toLang: "es" },
{ fromLang: "en", toLang: "yue" },
{ fromLang: "es", toLang: "en" },
{ fromLang: "is", toLang: "en" },
{ fromLang: "yue", toLang: "en" },
],
"Non-pivot languages were removed."
);
if (SpecialPowers.isDebugBuild) {
Assert.deepEqual(
sort(languagePairs),
sort([
{ fromLang: "en", toLang: "es" },
{ fromLang: "en", toLang: "yue" },
{ fromLang: "es", toLang: "en" },
{ fromLang: "is", toLang: "en" },
{ fromLang: "yue", toLang: "en" },
]),
"Non-pivot languages were removed on debug builds."
);
} else {
Assert.deepEqual(
sort(languagePairs),
sort(fromLanguagePairs),
"Non-pivot languages are retained on non-debug builds."
);
}
return cleanup();
});