Bug 1613985 - Use default for equivalent-to-default constructors/destructors in netwerk. r=dragana

Differential Revision: https://phabricator.services.mozilla.com/D65496

--HG--
extra : moz-landing-system : lando

netwerk/dns/DNS.cpp

@@ -356,7 +356,7 @@ AddrInfo::AddrInfo(const AddrInfo* src) {
   }
 }
 
-AddrInfo::~AddrInfo() {}
+AddrInfo::~AddrInfo() = default;
 
 void AddrInfo::AddAddress(NetAddrElement* address) {
   MOZ_ASSERT(address, "Cannot add the address to an uninitialized list");

netwerk/ipc/ChannelEventQueue.h

@@ -173,7 +173,7 @@ class ChannelEventQueue final {
 
  private:
   // Private destructor, to discourage deletion outside of Release():
-  ~ChannelEventQueue() {}
+  ~ChannelEventQueue() = default;
 
   void SuspendInternal();
   void ResumeInternal();

netwerk/ipc/SocketProcessImpl.cpp

@@ -26,7 +26,7 @@ LazyLogModule gSocketProcessLog("socketprocess");
 SocketProcessImpl::SocketProcessImpl(ProcessId aParentPid)
     : ProcessChild(aParentPid) {}
 
-SocketProcessImpl::~SocketProcessImpl() {}
+SocketProcessImpl::~SocketProcessImpl() = default;
 
 bool SocketProcessImpl::Init(int aArgc, char* aArgv[]) {
 #ifdef OS_POSIX

netwerk/protocol/http/nsCORSListenerProxy.cpp

@@ -230,7 +230,7 @@ bool nsPreflightCache::CacheEntry::CheckRequest(
       return e.token.Equals(header, comparator);
     }
 
-    const nsCaseInsensitiveCStringComparator comparator;
+    const nsCaseInsensitiveCStringComparator comparator{};
   } checker;
   for (uint32_t i = 0; i < aHeaders.Length(); ++i) {
     if (!mHeaders.Contains(aHeaders[i], checker)) {

netwerk/system/netlink/NetlinkService.cpp

@@ -67,7 +67,7 @@ static void GetAddrStr(const in_common_addr* aAddr, uint8_t aFamily,
 
 class NetlinkAddress {
  public:
-  NetlinkAddress() {}
+  NetlinkAddress() = default;
 
   uint8_t Family() const { return mIfam.ifa_family; }
   uint32_t GetIndex() const { return mIfam.ifa_index; }
@@ -236,7 +236,7 @@ class NetlinkNeighbor {
 
 class NetlinkLink {
  public:
-  NetlinkLink() {}
+  NetlinkLink() = default;
 
   bool IsUp() const {
     return (mIface.ifi_flags & IFF_RUNNING) &&
@@ -586,7 +586,7 @@ class NetlinkRtMsg : public NetlinkMsg {
 NetlinkService::LinkInfo::LinkInfo(UniquePtr<NetlinkLink>&& aLink)
     : mLink(std::move(aLink)), mIsUp(false) {}
 
-NetlinkService::LinkInfo::~LinkInfo() {}
+NetlinkService::LinkInfo::~LinkInfo() = default;
 
 bool NetlinkService::LinkInfo::UpdateStatus() {
   LOG(("NetlinkService::LinkInfo::UpdateStatus"));

netwerk/test/TestCommon.h

@@ -27,7 +27,7 @@ class WaitForCondition final : public nsIRunnable {
   void Notify() { NS_DispatchToMainThread(this); }
 
  private:
-  virtual ~WaitForCondition() {}
+  virtual ~WaitForCondition() = default;
 
   NS_IMETHOD Run() override {
     MOZ_ASSERT(NS_IsMainThread());

netwerk/test/gtest/TestPACMan.cpp

@@ -42,11 +42,12 @@ class nsTestDHCPClient final : public nsIDHCPClient {
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIDHCPCLIENT
 
-  nsTestDHCPClient(){};
+  nsTestDHCPClient() = default;
+
   nsresult Init() { return NS_OK; };
 
  private:
-  ~nsTestDHCPClient(){};
+  ~nsTestDHCPClient() = default;
 };
 
 NS_IMETHODIMP

netwerk/test/gtest/TestPartiallySeekableInputStream.cpp

@@ -44,7 +44,7 @@ class NonSeekableStream final : public nsIInputStream {
   }
 
  private:
-  ~NonSeekableStream() {}
+  ~NonSeekableStream() = default;
 };
 
 NS_IMPL_ISUPPORTS(NonSeekableStream, nsIInputStream)