Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1645511 - Improve the provider manager's provider.updateBehavior calls. r=mak

Browse Source 
I considered wrapping `provider.tryMethod("updateBehavior", queryContext)` in a
promise in case there are implementations that aren't async or don't return a
promise. But there's only one implementation of `updateBehavior`, it's async,
and we probably won't end up with any more implementations, so for simplicity I
didn't.

Differential Revision: https://phabricator.services.mozilla.com/D79559
This commit is contained in:
Drew Willcoxon 2020-06-16 01:09:26 +00:00
parent 7024c06712
commit 15284e839e
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
browser/components/urlbar/UrlbarProvidersManager.jsm
View File

@ -206,12 +206,21 @@ class ProvidersManager {
}
// Update the behavior of extension providers.
let updateBehaviorPromises = [];
for (let provider of this.providers) {
if (
provider.type == UrlbarUtils.PROVIDER_TYPE.EXTENSION &&
provider.name != "Omnibox"
) {
await provider.tryMethod("updateBehavior", queryContext);
updateBehaviorPromises.push(
provider.tryMethod("updateBehavior", queryContext)
);
}
}
if (updateBehaviorPromises.length) {
await Promise.all(updateBehaviorPromises);
if (query.canceled) {
return;
}
}